You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by as...@apache.org on 2020/11/20 15:24:34 UTC

[airflow] branch v1-10-stable updated: Silence DagBag INFO logs during upgrade check (#12507)

This is an automated email from the ASF dual-hosted git repository.

ash pushed a commit to branch v1-10-stable
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/v1-10-stable by this push:
     new 8e5f722  Silence DagBag INFO logs during upgrade check (#12507)
8e5f722 is described below

commit 8e5f7227a4b00149c326637bb51409b8da6caa81
Author: Ash Berlin-Taylor <as...@firemirror.com>
AuthorDate: Fri Nov 20 15:21:15 2020 +0000

    Silence DagBag INFO logs during upgrade check (#12507)
    
    By default, the logs would appear in the middle of the status stream,
    which makes it slightly harder to parse the output.
    
    Before:
    
    ```
    ============================================= STATUS =============================================
    
    Legacy UI is deprecated by default......................................................SUCCESS
    Users must set a kubernetes.pod_template_file value.....................................FAIL
    Changes in import paths of hooks, operators, sensors and others.........................FAIL
    Remove airflow.AirflowMacroPlugin class.................................................SUCCESS
    [2020-11-20 14:26:04,083] {__init__.py:50} INFO - Using executor SequentialExecutor
    [2020-11-20 14:26:04,083] {dagbag.py:417} INFO - Filling up the DagBag from /home/ash/airflow/dags
    Jinja Template Variables cannot be undefined............................................SUCCESS
    ```
    
    After:
    
    ```
    ============================================= STATUS =============================================
    
    Legacy UI is deprecated by default......................................................SUCCESS
    Users must set a kubernetes.pod_template_file value.....................................FAIL
    Changes in import paths of hooks, operators, sensors and others.........................FAIL
    Remove airflow.AirflowMacroPlugin class.................................................SUCCESS
    Jinja Template Variables cannot be undefined............................................SUCCESS
    ```
---
 airflow/upgrade/rules/undefined_jinja_varaibles.py | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/airflow/upgrade/rules/undefined_jinja_varaibles.py b/airflow/upgrade/rules/undefined_jinja_varaibles.py
index b97cfbc..7e39be4 100644
--- a/airflow/upgrade/rules/undefined_jinja_varaibles.py
+++ b/airflow/upgrade/rules/undefined_jinja_varaibles.py
@@ -17,6 +17,7 @@
 
 from __future__ import absolute_import
 
+import logging
 import re
 
 import jinja2
@@ -131,8 +132,14 @@ The user should do either of the following to fix this -
 
     def check(self, dagbag=None):
         if not dagbag:
-            dag_folder = conf.get("core", "dags_folder")
-            dagbag = DagBag(dag_folder)
+            logger = logging.root
+            old_level = logger.level
+            try:
+                logger.setLevel(logging.ERROR)
+                dag_folder = conf.get("core", "dags_folder")
+                dagbag = DagBag(dag_folder)
+            finally:
+                logger.setLevel(old_level)
         dags = dagbag.dags
         messages = []
         for dag_id, dag in dags.items():