You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:13:36 UTC

[GitHub] [beam] KevinGG commented on a change in pull request #15023: [BEAM-10708] Save and load coders correctly

KevinGG commented on a change in pull request #15023:
URL: https://github.com/apache/beam/pull/15023#discussion_r654058633



##########
File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py
##########
@@ -336,7 +344,8 @@ def write(self, values, *labels):
           val = v.SerializeToString()
         else:
           val = v
-        f.write(self._default_pcoder.encode(val) + b'\n')
+          self.save_pcoder(coders.registry.get_coder(type(val)), *labels)

Review comment:
       Discussed offline, we don't have and will discourage this execution route to write arbitrary typed elements into streaming cache directly. Raise TypeError here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org