You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/06 19:27:00 UTC
[jira] [Work logged] (BEAM-13988) Update mtime package to use time.UnixMilli()
[ https://issues.apache.org/jira/browse/BEAM-13988?focusedWorklogId=767388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767388 ]
ASF GitHub Bot logged work on BEAM-13988:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/22 19:26
Start Date: 06/May/22 19:26
Worklog Time Spent: 10m
Work Description: asf-ci commented on PR #17578:
URL: https://github.com/apache/beam/pull/17578#issuecomment-1119946545
Can one of the admins verify this patch?
Issue Time Tracking
-------------------
Worklog Id: (was: 767388)
Time Spent: 0.5h (was: 20m)
> Update mtime package to use time.UnixMilli()
> --------------------------------------------
>
> Key: BEAM-13988
> URL: https://issues.apache.org/jira/browse/BEAM-13988
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Jack McCluskey
> Priority: P3
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Update the `mtime` package's [FromTime() function|https://github.com/apache/beam/blob/5345834a86c422347556e0bce7e5dd20e4854e44/sdks/go/pkg/beam/core/graph/mtime/time.go#L67] to use the `time` package's [UnixMilli() function|https://pkg.go.dev/time#UnixMilli] instead of doing the unit conversion from nanoseconds to milliseconds once the minimum Go version for the Beam Go SDK is at or above 1.17.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)