You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Ismael Juma (JIRA)" <ji...@apache.org> on 2016/02/20 19:02:18 UTC

[jira] [Commented] (KAFKA-3255) Extra unit tests for NetworkClient.connectionDelay(Node node, long now)

    [ https://issues.apache.org/jira/browse/KAFKA-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155707#comment-15155707 ] 

Ismael Juma commented on KAFKA-3255:
------------------------------------

Thanks for the patch. Would you consider submitting a pull request as per the following?

https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes

> Extra unit tests for NetworkClient.connectionDelay(Node node, long now)
> -----------------------------------------------------------------------
>
>                 Key: KAFKA-3255
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3255
>             Project: Kafka
>          Issue Type: Test
>          Components: core
>    Affects Versions: 0.9.0.1
>            Reporter: Frank Scholten
>            Priority: Trivial
>              Labels: test
>             Fix For: 0.9.1.0
>
>         Attachments: KAFKA-3255.patch
>
>
> I am exploring the Kafka codebase and noticed that this method was not covered so I added some tests. Also saw that the method isConnecting is not used anywhere in the code. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)