You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dahlem <gi...@git.apache.org> on 2015/10/23 16:16:41 UTC
[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...
GitHub user dahlem opened a pull request:
https://github.com/apache/spark/pull/9252
[SPARK-11284] [ML] ALS produces float predictions instead of double
@mengxr
This pull request just changes the float predictions into doubles with corresponding changes to use the double precision BLAS APIs.
[LIRA issue SPARK-11284] (https://issues.apache.org/jira/browse/SPARK-11284)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dahlem/spark ddahlem_ALS_double_predictions_23102015
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9252
----
commit 97d556a893bad735fb8707a4514ac8fc1ca1469a
Author: Dominik Dahlem <do...@gmail.combination>
Date: 2015-10-23T14:02:23Z
use doubles instead of floats
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9252#issuecomment-150586598
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/9252#issuecomment-150700335
Shouldn't this be fixed/casted in the `RegressionEvaluator` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...
Posted by dahlem <gi...@git.apache.org>.
Github user dahlem closed the pull request at:
https://github.com/apache/spark/pull/9252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9252#issuecomment-150607991
@dahlem Any issue with float precision? The ratings do not have high precision anyway. Changing it to double precision increases the shuffle size by a lot. If you want to make the `RegressionEvaluator` work with `ALS`, you can cast the label type to Double in `RegressionEvaluator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9252#issuecomment-151371779
@dahlem If you plan to make a new pull request, could you close this PR manually? We don't have direct access to close Spark PRs. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11284] [ML] ALS produces float predicti...
Posted by dahlem <gi...@git.apache.org>.
Github user dahlem commented on the pull request:
https://github.com/apache/spark/pull/9252#issuecomment-151344091
That makes sense. I fixed it on my branch and will create a pull request
against a new ticket.
On Fri, Oct 23, 2015 at 10:43 PM, Felix Cheung <no...@github.com>
wrote:
> Shouldn't this be fixed/casted in the RegressionEvaluator instead?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/9252#issuecomment-150700335>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org