You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/10 23:51:00 UTC

[GitHub] [iceberg] shardulm94 commented on a change in pull request #1189: Spark: Support ORC vectorized reads

shardulm94 commented on a change in pull request #1189:
URL: https://github.com/apache/iceberg/pull/1189#discussion_r453124496



##########
File path: spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java
##########
@@ -75,6 +103,16 @@
       }
 
       iter = builder.build();
+    } else if (task.file().format() == FileFormat.ORC) {
+      iter = ORC.read(location)
+          .project(expectedSchema)

Review comment:
       I will change this to not project constant columns to avoid materializing a `ColumnVector` similar to what we did in #1191




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org