You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/15 09:20:10 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #3085: feat(dora): e2e
warren830 opened a new pull request, #3085:
URL: https://github.com/apache/incubator-devlake/pull/3085
relate to #2853
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
# Summary
add e2e for change_lead_time_calculator.go and issue_deploy_connector.go
modify e2e for cicd_task_env_enricher.go
fix minor bugs in dora and github
### Does this close any open issues?
relate to #2853
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #3085: feat(dora): e2e
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #3085:
URL: https://github.com/apache/incubator-devlake/pull/3085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #3085: feat(dora): e2e
Posted by GitBox <gi...@apache.org>.
klesh commented on PR #3085:
URL: https://github.com/apache/incubator-devlake/pull/3085#issuecomment-1250654724
Hey, guys, why this PR got merged while the tests failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3085: feat(dora): e2e
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3085:
URL: https://github.com/apache/incubator-devlake/pull/3085#discussion_r973930985
##########
plugins/github/tasks/commit_convertor.go:
##########
@@ -33,7 +33,7 @@ import (
var ConvertCommitsMeta = core.SubTaskMeta{
Name: "convertCommits",
EntryPoint: ConvertCommits,
- EnabledByDefault: false,
+ EnabledByDefault: true,
Review Comment:
>
This is fixed in other prs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #3085: feat(dora): e2e
Posted by GitBox <gi...@apache.org>.
keon94 commented on code in PR #3085:
URL: https://github.com/apache/incubator-devlake/pull/3085#discussion_r972590837
##########
plugins/github/tasks/commit_convertor.go:
##########
@@ -33,7 +33,7 @@ import (
var ConvertCommitsMeta = core.SubTaskMeta{
Name: "convertCommits",
EntryPoint: ConvertCommits,
- EnabledByDefault: false,
+ EnabledByDefault: true,
Review Comment:
@warren830 this has broken the e2e tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org