You are viewing a plain text version of this content. The canonical link for it is here.
Posted to woden-dev@ws.apache.org by hu...@apache.org on 2006/09/08 11:23:51 UTC
svn commit: r441452 - in
/incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20:
BindingImpl.java InterfaceFaultImpl.java InterfaceImpl.java
InterfaceOperationImpl.java ServiceImpl.java
Author: hughesj
Date: Fri Sep 8 02:23:50 2006
New Revision: 441452
URL: http://svn.apache.org/viewvc?view=rev&rev=441452
Log:
setName methods shouldn't through IllegalArgumentException when passed a null.
How else can a client program unset the name attribute!? So I've removed the
exception throwing.
Modified:
incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/BindingImpl.java
incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceFaultImpl.java
incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceImpl.java
incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceOperationImpl.java
incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/ServiceImpl.java
Modified: incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/BindingImpl.java
URL: http://svn.apache.org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/BindingImpl.java?view=diff&rev=441452&r1=441451&r2=441452
==============================================================================
--- incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/BindingImpl.java (original)
+++ incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/BindingImpl.java Fri Sep 8 02:23:50 2006
@@ -132,10 +132,7 @@
* @see org.apache.woden.wsdl20.xml.BindingElement#setName(javax.xml.namespace.QName)
*/
public void setName(NCName name) {
- if (name == null) {
- throw new IllegalArgumentException("name cannot be null.");
- }
- fName = new NCName(name.toString());
+ fName = name;
}
/* (non-Javadoc)
Modified: incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceFaultImpl.java
URL: http://svn.apache.org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceFaultImpl.java?view=diff&rev=441452&r1=441451&r2=441452
==============================================================================
--- incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceFaultImpl.java (original)
+++ incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceFaultImpl.java Fri Sep 8 02:23:50 2006
@@ -89,10 +89,7 @@
*/
public void setName(NCName name)
{
- if (name == null) {
- throw new IllegalArgumentException("name cannot be null.");
- }
- fName = new NCName(name.toString());
+ fName = name;
}
/*
Modified: incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceImpl.java
URL: http://svn.apache.org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceImpl.java?view=diff&rev=441452&r1=441451&r2=441452
==============================================================================
--- incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceImpl.java (original)
+++ incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceImpl.java Fri Sep 8 02:23:50 2006
@@ -213,10 +213,7 @@
// to create an InterfaceImpl and set the name without first having added
// the interfaceimpl to the DescriptionElement.
public void setName(NCName name) {
- if (name == null) {
- throw new IllegalArgumentException("name cannot be null.");
- }
- fName = new NCName(name.toString());
+ fName = name;
}
/*
Modified: incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceOperationImpl.java
URL: http://svn.apache.org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceOperationImpl.java?view=diff&rev=441452&r1=441451&r2=441452
==============================================================================
--- incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceOperationImpl.java (original)
+++ incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/InterfaceOperationImpl.java Fri Sep 8 02:23:50 2006
@@ -121,10 +121,7 @@
*/
public void setName(NCName name)
{
- if (name == null) {
- throw new IllegalArgumentException("name cannot be null.");
- }
- fName = new NCName(name.toString());
+ fName = name;
}
/*
Modified: incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/ServiceImpl.java
URL: http://svn.apache.org/viewvc/incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/ServiceImpl.java?view=diff&rev=441452&r1=441451&r2=441452
==============================================================================
--- incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/ServiceImpl.java (original)
+++ incubator/woden/trunk/java/src/org/apache/woden/internal/wsdl20/ServiceImpl.java Fri Sep 8 02:23:50 2006
@@ -134,10 +134,7 @@
* @see org.apache.woden.wsdl20.xml.ServiceElement#setName(NCName)
*/
public void setName(NCName name) {
- if (name == null) {
- throw new IllegalArgumentException("name cannot be null.");
- }
- fName = new NCName(name.toString());
+ fName = name;
}
/* (non-Javadoc)
---------------------------------------------------------------------
To unsubscribe, e-mail: woden-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: woden-dev-help@ws.apache.org