[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

["Jason Rosenberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293913#comment-14293913 ] 

Jason Rosenberg commented on KAFKA-1901:
----------------------------------------

At the very least, this could be updated to just log at INFO level, and have it state that the version was not available in the manifest (rather than log an NPE).

> Move Kafka version to be generated in code by build (instead of in manifest)
> ----------------------------------------------------------------------------
>
>                 Key: KAFKA-1901
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1901
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2
>            Reporter: Jason Rosenberg
>
> With 0.8.2 (rc2), I've started seeing this warning in the logs of apps deployed to our staging (both server and client):
> {code}
> 2015-01-23 00:55:25,273  WARN [async-message-sender-0] common.AppInfo$ - Can't read Kafka version from MANIFEST.MF. Possible cause: java.lang.NullPointerException
> {code}
> The issues is that in our deployment, apps are deployed with single 'shaded' jars (e.g. using the maven shade plugin).  This means the MANIFEST.MF file won't have a kafka version.  Instead, suggest the kafka build generate the proper version in code, as part of the build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)