You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kevin Lyda <ke...@ie.suberic.net> on 2013/08/21 20:13:58 UTC
Re: Review Request 13709: Fixed typos and added .gitignore
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/
-----------------------------------------------------------
(Updated Aug. 21, 2013, 6:13 p.m.)
Review request for mesos.
Changes
-------
Thanks, fixed the title so it's clear.
Summary (updated)
-----------------
Fixed typos and added .gitignore
Bugs: MESOS-654
https://issues.apache.org/jira/browse/MESOS-654
Repository: mesos-git
Description
-------
Fixed a few typos, added a .gitignore, removed a generated file.
Diffs
-----
.gitignore PRE-CREATION
3rdparty/libprocess/install-sh 6781b98
README e94531d
src/common/values.cpp ce26119
src/linux/cgroups.cpp b97a89c
src/log/coordinator.cpp 6e6466f
src/log/log.cpp aea06e7
src/master/master.cpp d53b8bb
src/slave/slave.cpp 92a0a7e
src/tests/allocator_tests.cpp c57da6e
src/tests/resources_tests.cpp 964a1b6
src/tests/status_update_manager_tests.cpp cf420e4
Diff: https://reviews.apache.org/r/13709/diff/
Testing
-------
git clean -fxd
./bootstrap
cd build
../configure
make
make check
All these work as they did before. git status is now clean when the tree is built (unless there have been code changes made). git diff only shows code changes, not stuff from generated files.
Thanks,
Kevin Lyda
Re: Review Request 13709: Fixed typos and added .gitignore
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/#review84920
-----------------------------------------------------------
Can we split this in two? I am not sure about our policy with regards to gitignore, but the typo fixes are definitely useful!
- Niklas Nielsen
On Aug. 22, 2013, 12:06 a.m., Kevin Lyda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13709/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 12:06 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a few typos, added a .gitignore, removed a generated file.
>
>
> Diffs
> -----
>
> .gitignore PRE-CREATION
> 3rdparty/libprocess/install-sh 6781b98
> README e94531d
> src/common/values.cpp ce26119
> src/linux/cgroups.cpp b97a89c
> src/log/coordinator.cpp 6e6466f
> src/log/log.cpp aea06e7
> src/master/master.cpp d53b8bb
> src/slave/slave.cpp 92a0a7e
> src/tests/allocator_tests.cpp c57da6e
> src/tests/resources_tests.cpp 964a1b6
> src/tests/status_update_manager_tests.cpp cf420e4
>
> Diff: https://reviews.apache.org/r/13709/diff/
>
>
> Testing
> -------
>
> git clean -fxd
> ./bootstrap
> cd build
> ../configure
> make
> make check
>
> All these work as they did before. git status is now clean when the tree is built (unless there have been code changes made). git diff only shows code changes, not stuff from generated files.
>
>
> Thanks,
>
> Kevin Lyda
>
>
Re: Review Request 13709: Fixed typos and added .gitignore
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/#review84933
-----------------------------------------------------------
Bad patch!
Reviews applied: [13709]
Failed command: ./support/apply-review.sh -n -r 13709
Error:
2015-05-22 17:04:58 URL:https://reviews.apache.org/r/13709/diff/raw/ [21553/21553] -> "13709.patch" [1]
error: README: does not exist in index
error: patch failed: src/linux/cgroups.cpp:1424
error: src/linux/cgroups.cpp: patch does not apply
error: patch failed: src/log/coordinator.cpp:433
error: src/log/coordinator.cpp: patch does not apply
error: patch failed: src/log/log.cpp:30
error: src/log/log.cpp: patch does not apply
error: patch failed: src/master/master.cpp:927
error: src/master/master.cpp: patch does not apply
error: patch failed: src/slave/slave.cpp:460
error: src/slave/slave.cpp: patch does not apply
error: src/tests/allocator_tests.cpp: does not exist in index
error: patch failed: src/tests/status_update_manager_tests.cpp:743
error: src/tests/status_update_manager_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Aug. 22, 2013, 7:06 a.m., Kevin Lyda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13709/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 7:06 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a few typos, added a .gitignore, removed a generated file.
>
>
> Diffs
> -----
>
> .gitignore PRE-CREATION
> 3rdparty/libprocess/install-sh 6781b98
> README e94531d
> src/common/values.cpp ce26119
> src/linux/cgroups.cpp b97a89c
> src/log/coordinator.cpp 6e6466f
> src/log/log.cpp aea06e7
> src/master/master.cpp d53b8bb
> src/slave/slave.cpp 92a0a7e
> src/tests/allocator_tests.cpp c57da6e
> src/tests/resources_tests.cpp 964a1b6
> src/tests/status_update_manager_tests.cpp cf420e4
>
> Diff: https://reviews.apache.org/r/13709/diff/
>
>
> Testing
> -------
>
> git clean -fxd
> ./bootstrap
> cd build
> ../configure
> make
> make check
>
> All these work as they did before. git status is now clean when the tree is built (unless there have been code changes made). git diff only shows code changes, not stuff from generated files.
>
>
> Thanks,
>
> Kevin Lyda
>
>
Re: Review Request 13709: Fixed typos and added .gitignore
Posted by Michael Park <mc...@gmail.com>.
> On Aug. 22, 2013, 11:38 p.m., Ben Mahler wrote:
> > I'm ok with adding these kinds of things to .gitignore.
>
> Marco Massenzio wrote:
> I'm confused here - see comments to https://reviews.apache.org/r/33448
>
> Also, what's the relationship with .gitignore-template? are we dropping it?
>
> To be clear, I fully support these changes (I was the one proposing them :) but would like to understand what's changed and how do we manage .gitignore and .gitignore-template.
> I'm confused here - see comments to https://reviews.apache.org/r/33448
Looks like this patch is from 2013, whereas the discussion in BenM's [link](http://markmail.org/thread/7mu6lzkv3b6hngww) is from 2014.
> Also, what's the relationship with .gitignore-template? are we dropping it?
I think the `.gitignore-template` will stay. Although we might consider moving it to `support/gitignore`, since we now have other similar templates: `support/reviewboardrc` and `support/clang-format` which get symlinked as `.reviewboardrc` and `.clang-format` respectively.
> how do we manage .gitignore and .gitignore-template.
By default `bootstrap` symlinks `.gitignore-template` to `.gitignore` if there doesn't already exist a `.gitignore`. But it's likely that most people would diverge from the template by copying `.gitignore-template` to `.gitignore` instead and augmenting it with whatever else they want to further ignore (e.g. their IDE-specific settings).
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/#review25439
-----------------------------------------------------------
On Aug. 22, 2013, 7:06 a.m., Kevin Lyda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13709/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 7:06 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a few typos, added a .gitignore, removed a generated file.
>
>
> Diffs
> -----
>
> .gitignore PRE-CREATION
> 3rdparty/libprocess/install-sh 6781b98
> README e94531d
> src/common/values.cpp ce26119
> src/linux/cgroups.cpp b97a89c
> src/log/coordinator.cpp 6e6466f
> src/log/log.cpp aea06e7
> src/master/master.cpp d53b8bb
> src/slave/slave.cpp 92a0a7e
> src/tests/allocator_tests.cpp c57da6e
> src/tests/resources_tests.cpp 964a1b6
> src/tests/status_update_manager_tests.cpp cf420e4
>
> Diff: https://reviews.apache.org/r/13709/diff/
>
>
> Testing
> -------
>
> git clean -fxd
> ./bootstrap
> cd build
> ../configure
> make
> make check
>
> All these work as they did before. git status is now clean when the tree is built (unless there have been code changes made). git diff only shows code changes, not stuff from generated files.
>
>
> Thanks,
>
> Kevin Lyda
>
>
Re: Review Request 13709: Fixed typos and added .gitignore
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On Aug. 22, 2013, 11:38 p.m., Ben Mahler wrote:
> > I'm ok with adding these kinds of things to .gitignore.
I'm confused here - see comments to https://reviews.apache.org/r/33448
Also, what's the relationship with .gitignore-template? are we dropping it?
To be clear, I fully support these changes (I was the one proposing them :) but would like to understand what's changed and how do we manage .gitignore and .gitignore-template.
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/#review25439
-----------------------------------------------------------
On Aug. 22, 2013, 7:06 a.m., Kevin Lyda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13709/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 7:06 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a few typos, added a .gitignore, removed a generated file.
>
>
> Diffs
> -----
>
> .gitignore PRE-CREATION
> 3rdparty/libprocess/install-sh 6781b98
> README e94531d
> src/common/values.cpp ce26119
> src/linux/cgroups.cpp b97a89c
> src/log/coordinator.cpp 6e6466f
> src/log/log.cpp aea06e7
> src/master/master.cpp d53b8bb
> src/slave/slave.cpp 92a0a7e
> src/tests/allocator_tests.cpp c57da6e
> src/tests/resources_tests.cpp 964a1b6
> src/tests/status_update_manager_tests.cpp cf420e4
>
> Diff: https://reviews.apache.org/r/13709/diff/
>
>
> Testing
> -------
>
> git clean -fxd
> ./bootstrap
> cd build
> ../configure
> make
> make check
>
> All these work as they did before. git status is now clean when the tree is built (unless there have been code changes made). git diff only shows code changes, not stuff from generated files.
>
>
> Thanks,
>
> Kevin Lyda
>
>
Re: Review Request 13709: Fixed typos and added .gitignore
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/#review25439
-----------------------------------------------------------
Ship it!
I'm ok with adding these kinds of things to .gitignore.
- Ben Mahler
On Aug. 22, 2013, 7:06 a.m., Kevin Lyda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13709/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 7:06 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed a few typos, added a .gitignore, removed a generated file.
>
>
> Diffs
> -----
>
> .gitignore PRE-CREATION
> 3rdparty/libprocess/install-sh 6781b98
> README e94531d
> src/common/values.cpp ce26119
> src/linux/cgroups.cpp b97a89c
> src/log/coordinator.cpp 6e6466f
> src/log/log.cpp aea06e7
> src/master/master.cpp d53b8bb
> src/slave/slave.cpp 92a0a7e
> src/tests/allocator_tests.cpp c57da6e
> src/tests/resources_tests.cpp 964a1b6
> src/tests/status_update_manager_tests.cpp cf420e4
>
> Diff: https://reviews.apache.org/r/13709/diff/
>
>
> Testing
> -------
>
> git clean -fxd
> ./bootstrap
> cd build
> ../configure
> make
> make check
>
> All these work as they did before. git status is now clean when the tree is built (unless there have been code changes made). git diff only shows code changes, not stuff from generated files.
>
>
> Thanks,
>
> Kevin Lyda
>
>
Re: Review Request 13709: Fixed typos and added .gitignore
Posted by Kevin Lyda <ke...@ie.suberic.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13709/
-----------------------------------------------------------
(Updated Aug. 22, 2013, 7:06 a.m.)
Review request for mesos.
Changes
-------
I actually think the tool cruft files make sense - vi and eclipse would be common tools. So I hope you don't mind but I added it.
I also added .gitignore but do note that it will not affect changes to .gitignore files that are in the tree - just ones you make further in the tree and which don't already exist. If someone wants to make, say, src/.gitignore they will have to explicitly add it w/o any indication from git status that it's missing. If you change ./.gitignore those changes will be noticed.
Bugs: MESOS-654
https://issues.apache.org/jira/browse/MESOS-654
Repository: mesos-git
Description
-------
Fixed a few typos, added a .gitignore, removed a generated file.
Diffs (updated)
-----
.gitignore PRE-CREATION
3rdparty/libprocess/install-sh 6781b98
README e94531d
src/common/values.cpp ce26119
src/linux/cgroups.cpp b97a89c
src/log/coordinator.cpp 6e6466f
src/log/log.cpp aea06e7
src/master/master.cpp d53b8bb
src/slave/slave.cpp 92a0a7e
src/tests/allocator_tests.cpp c57da6e
src/tests/resources_tests.cpp 964a1b6
src/tests/status_update_manager_tests.cpp cf420e4
Diff: https://reviews.apache.org/r/13709/diff/
Testing
-------
git clean -fxd
./bootstrap
cd build
../configure
make
make check
All these work as they did before. git status is now clean when the tree is built (unless there have been code changes made). git diff only shows code changes, not stuff from generated files.
Thanks,
Kevin Lyda