[GitHub] [apisix] dickens7 commented on a change in pull request #2174: optimize set nginx conf env

[GitBox <gi...@apache.org>]

dickens7 commented on a change in pull request #2174:
URL: https://github.com/apache/apisix/pull/2174#discussion_r487361283



##########
File path: conf/config-default.yaml
##########
@@ -115,6 +115,8 @@ nginx_config:                     # config for render the template to genarate n
   worker_shutdown_timeout: 240s     # timeout for a graceful shutdown of worker processes
   event:
     worker_connections: 10620
+  envs:
+    - APISIX_PROFILE

Review comment:
       From the definition of APISIX_PROFILE, you are right. But I think this configuration should be defined in the configuration file instead of environment variables. I think can use the environment variable definition part of the configuration. When there is a corresponding environment variable definition, the environment variable is preferred




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org