[GitHub] [helix] kaisun2000 commented on a change in pull request #1456: Fix Periodic rebalancer Timer leak

[GitBox <gi...@apache.org>]

kaisun2000 commented on a change in pull request #1456:
URL: https://github.com/apache/helix/pull/1456#discussion_r503687802



##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -172,11 +173,15 @@
   private boolean _inMaintenanceMode;
 
   /**
-   * The timer that can periodically run the rebalancing pipeline. The timer will start if there is
-   * one resource group has the config to use the timer.
+   * The executors that can periodically run the rebalancing pipeline. A
+   * SingleThreadScheduledExecutor will start if there is one resource group has the config to do
+   * periodically rebalance.

Review comment:
       We totally only have one SingleThreadScheduledExecutor at most for each genericHelixController object, right? This sounds like per resource group has one. Can we make it clear the life cycle of SingleThreadScheduledExecutor is the same as genericHelixController?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org