You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/07/16 00:12:38 UTC

[GitHub] spark pull request #18323: [SPARK-21117][SQL] Built-in SQL Function Support ...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18323#discussion_r127595711
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala ---
    @@ -1186,3 +1186,51 @@ case class BRound(child: Expression, scale: Expression)
         with Serializable with ImplicitCastInputTypes {
       def this(child: Expression) = this(child, Literal(0))
     }
    +
    +/**
    + *  Returns the bucket number into which
    + *  the value of this expression would fall after being evaluated.
    + *
    + * @param expr is the expression for which the histogram is being created
    + * @param minValue is an expression that resolves
    + *                 to the minimum end point of the acceptable range for expr
    + * @param maxValue is an expression that resolves
    + *                 to the maximum end point of the acceptable range for expr
    + * @param numBucket is an An expression that resolves to
    --- End diff --
    
    `an An` -> `an`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org