You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by GitBox <gi...@apache.org> on 2019/02/08 18:23:39 UTC

[GitHub] vlsi commented on issue #980: [CALCITE-2736] Update the ReduceExpressionsRule to better expose options

vlsi commented on issue #980: [CALCITE-2736] Update the ReduceExpressionsRule to better expose options
URL: https://github.com/apache/calcite/pull/980#issuecomment-461897840
 
 
   >Another option is using builder-esque pattern with an options object. I chose the second option because it benefits from being able to have additional options added without further refactoring
   
   Those options do not invalidate each other. Even builder benefits from enum types.
   
   
   @jacques-n , there's already an enum for `UnknownAs`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services