[GitHub] [apisix] leslie-tsang commented on a diff in pull request #7365: feat(deployment): provide conf server in control_plane role

[GitBox <gi...@apache.org>]

leslie-tsang commented on code in PR #7365:
URL: https://github.com/apache/apisix/pull/7365#discussion_r912679833


##########
apisix/cli/schema.lua:
##########
@@ -272,9 +272,43 @@ local deployment_schema = {
     traditional = {
         properties = {
             etcd = etcd_schema,
+            role_traditional = {
+                properties = {
+                    config_provider = {
+                        enum = {"etcd"}
+                    },
+                },
+                required = {"config_provider"}
+            }
         },
         required = {"etcd"}
     },
+    control_plane = {
+        properties = {
+            etcd = etcd_schema,
+            role_control_plane = {
+                properties = {
+                    config_provider = {
+                        enum = {"etcd"}
+                    },
+                    conf_server = {
+                        properties = {
+                            listen = {
+                                type = "string",
+                                default = "0.0.0.0:9280",

Review Comment:
   ```suggestion
                                   default = "127.0.0.1:9280",
   ```
   Would be better to use `127.0.0.1:9280` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org