You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/13 12:00:12 UTC

[GitHub] [fineract] galovics commented on a diff in pull request #2598: FINERACT-1678: Soft-lock Loan COB relevant loan accounts

galovics commented on code in PR #2598:
URL: https://github.com/apache/fineract/pull/2598#discussion_r969530318


##########
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanCOBPartitioner.java:
##########
@@ -65,15 +66,15 @@ public Map<String, ExecutionContext> partition(int gridSize) {
 
     private Map<String, ExecutionContext> getPartitions(int partitionSize, TreeMap<Long, String> cobBusinessStepMap) {
         Map<String, ExecutionContext> partitions = new HashMap<>();
-        List<Long> allNonClosedLoanIds = retrieveLoanIdService.retrieveLoanIds();
-        if (allNonClosedLoanIds.isEmpty()) {
+
+        if (loanIds == null || loanIds.isEmpty()) {

Review Comment:
   CollectionUtils.isEmpty



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org