You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Andras Piros (JIRA)" <ji...@apache.org> on 2018/06/28 13:41:00 UTC

[jira] [Commented] (OOZIE-3299) CoordStatusTransitXCommand logs shows wrong ACTION value

    [ https://issues.apache.org/jira/browse/OOZIE-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526314#comment-16526314 ] 

Andras Piros commented on OOZIE-3299:
-------------------------------------

[~Prabhu Joseph] so the fix would essentially consist of emptying {{DagXLogInfoService.ACTION}} while {{LogUtils#setLogInfo(CoordinatorJobBean cBean)}}, right?

> CoordStatusTransitXCommand logs shows wrong ACTION value
> --------------------------------------------------------
>
>                 Key: OOZIE-3299
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3299
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.3.1
>            Reporter: Prabhu Joseph
>            Priority: Major
>
> ISSUE:
> The logs from CoordStatusTransitXCommand with different coordinators shows wrong ACTION value. The action 0188706-180421101115209-oozie-oozi-W does 
> not belong to any of the coordinators. This is misleading while analyzing the oozie server logs.
> {code}
> oozie.log-2018-06-07-16:2018-06-07 16:13:17,301  INFO CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] GROUP[-] TOKEN[] APP[PVL_data_sync] JOB[0009039-180122185814644-oozie-oozi-C] ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job [0009039-180122185814644-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
> oozie.log-2018-06-07-16:2018-06-07 16:13:17,305  INFO CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awbti01] GROUP[-] TOKEN[] APP[sohe] JOB[0182017-180421101115209-oozie-oozi-C] ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job [0182017-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
> oozie.log-2018-06-07-16:2018-06-07 16:13:17,310  INFO CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[awdlc03] GROUP[-] TOKEN[] APP[PRD_COORDINATOR_INGESTION_CAD] JOB[0005634-171021095136703-oozie-oozi-C] ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job [0005634-171021095136703-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
> oozie.log-2018-06-07-16:2018-06-07 16:13:17,329  INFO CoordStatusTransitXCommand:520 - SERVER[bigdata2.openstacklocal] USER[a004163] GROUP[-] TOKEN[] APP[coordinator_inventory] JOB[0160434-180421101115209-oozie-oozi-C] ACTION[0188706-180421101115209-oozie-oozi-W@fs-move] Set coordinator job [0160434-180421101115209-oozie-oozi-C] status to 'RUNNING' from 'RUNNING'
> {code}
> Suspect:
> The logging is a shared service and every commands (or threads) uses it has own values for the fields like USER, GROUP, TOKEN, APP , JOB and ACTION. The CoordinatorJob won't have any ACTION details. While logging, since it does not have a action value, Log Service wrongly uses a value which is in memory and used by some other thread.
> Code Analysis:
> CoordStatusTransitXCommand - at start defines the parameters like GROUP, USER, JOB, TOKEN, APP and it does not have any ACTION.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/command/coord/CoordStatusTransitXCommand.java#L101
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/LogUtils.java#L46
> We need a fix like clear the log prefix before logging from CoordStatusTransitXCommand - which will remove stale ACTION value and won;t show any ACTION details
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/LogUtils.java#L172



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)