You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/20 11:53:28 UTC
[GitHub] [airflow] alexott opened a new pull request #19723: Databricks: add more methods to represent run state information
alexott opened a new pull request #19723:
URL: https://github.com/apache/airflow/pull/19723
This PR adds a warning about need to use XCOM if `get_run_state` function is used, plus adds more methods to retrieve information about run state
closes: #19357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755488516
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -419,6 +427,46 @@ def get_run_state(self, run_id: str) -> RunState:
state_message = state['state_message']
return RunState(life_cycle_state, result_state, state_message)
+ def get_run_state_str(self, run_id: str) -> str:
+ """
+ Return the string representation of RunState.
+
+ :param run_id: id of the run
+ :return: string describing run state
+ """
+ state = self.get_run_state(run_id)
+ run_state_str = (
+ f"State: {state.life_cycle_state}. Result: {state.result_state}. {state.state_message}"
+ )
Review comment:
How about putting this in `RunState`’s `__str__` and just call `str(state)` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19723:
URL: https://github.com/apache/airflow/pull/19723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r754264294
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -34,6 +34,8 @@
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
+RUN_STATE_FORMAT_STRING = "State: {}. Result: {}. {}"
Review comment:
Ok, addressed comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755035170
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -407,6 +407,14 @@ def get_run_state(self, run_id: str) -> RunState:
"""
Retrieves run state of the run.
+ Please note that any Airflow tasks that call the ``get_run_state`` method will result in
+ failure unless you have enabled xcom pickling. This can be done using the following
+ environment variable: ``AIRLFOW_CORE_ENABLE_XCOM_PICKLING=TRUE``
Review comment:
you're right. FIxed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#issuecomment-977160607
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r754011758
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -34,6 +34,8 @@
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
+RUN_STATE_FORMAT_STRING = "State: {}. Result: {}. {}"
Review comment:
Ok, will rework it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753902690
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -34,6 +34,8 @@
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
+RUN_STATE_FORMAT_STRING = "State: {}. Result: {}. {}"
Review comment:
Although this variable is really only used once and does not really need to be global in the first place. It is even better to just use an f-string in `get_run_state_str`, and make the test assert on complete messages, instead of importhing this constant. [It’s better to use literals in tests.](http://blog.jayfields.com/2008/02/testing-expect-literals.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753902690
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -34,6 +34,8 @@
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
+RUN_STATE_FORMAT_STRING = "State: {}. Result: {}. {}"
Review comment:
Although this variable is really only used once and does not really need to be global in the first place? Why not just use an f-string in `get_run_state_str`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753763623
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
thank you for review, addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755489391
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -419,6 +427,46 @@ def get_run_state(self, run_id: str) -> RunState:
state_message = state['state_message']
return RunState(life_cycle_state, result_state, state_message)
+ def get_run_state_str(self, run_id: str) -> str:
+ """
+ Return the string representation of RunState.
+
+ :param run_id: id of the run
+ :return: string describing run state
+ """
+ state = self.get_run_state(run_id)
+ run_state_str = (
+ f"State: {state.life_cycle_state}. Result: {state.result_state}. {state.state_message}"
+ )
Review comment:
That’s primarily because I’m not sure if it may break something inside airflow. I’m not expert in it (yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753759320
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
Also restructuredText requires code to use double ticks, not single.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755026201
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -407,6 +407,14 @@ def get_run_state(self, run_id: str) -> RunState:
"""
Retrieves run state of the run.
+ Please note that any Airflow tasks that call the ``get_run_state`` method will result in
+ failure unless you have enabled xcom pickling. This can be done using the following
+ environment variable: ``AIRLFOW_CORE_ENABLE_XCOM_PICKLING=TRUE``
+
+ If you do not want to enable xcom pickling then use the ``get_run_state_str`` method to get
+ string describing state, or ``get_run_state_lifecycle``, ``get_run_state_result``, or
+ ``get_run_state_message`` to get individual components of the run state.
Review comment:
```suggestion
If you do not want to enable xcom pickling, use the ``get_run_state_str`` method to get
a string describing state, or ``get_run_state_lifecycle``, ``get_run_state_result``, or
``get_run_state_message`` to get individual components of the run state.
```
Grammar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753902351
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -34,6 +34,8 @@
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
+RUN_STATE_FORMAT_STRING = "State: {}. Result: {}. {}"
Review comment:
It’d be better to use named placeholders here to avoid acciedental formatting errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755027720
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -419,6 +427,46 @@ def get_run_state(self, run_id: str) -> RunState:
state_message = state['state_message']
return RunState(life_cycle_state, result_state, state_message)
+ def get_run_state_str(self, run_id: str) -> str:
+ """
+ Returns string representation of RunState
Review comment:
The same applies for all docstrings in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r754005619
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -34,6 +34,8 @@
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
+RUN_STATE_FORMAT_STRING = "State: {}. Result: {}. {}"
Review comment:
it's also used in the test - I first used f-string, but just to avoid changing in two places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755025766
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -407,6 +407,14 @@ def get_run_state(self, run_id: str) -> RunState:
"""
Retrieves run state of the run.
+ Please note that any Airflow tasks that call the ``get_run_state`` method will result in
+ failure unless you have enabled xcom pickling. This can be done using the following
+ environment variable: ``AIRLFOW_CORE_ENABLE_XCOM_PICKLING=TRUE``
Review comment:
Is this the correct variable? I think you need double underscores?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755026459
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -419,6 +427,46 @@ def get_run_state(self, run_id: str) -> RunState:
state_message = state['state_message']
return RunState(life_cycle_state, result_state, state_message)
+ def get_run_state_str(self, run_id: str) -> str:
+ """
+ Returns string representation of RunState
Review comment:
```suggestion
Returns the string representation of RunState.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753759296
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
```suggestion
"""Retrieves run state of the run.
Please note that any Airflow tasks that call the ``get_run_state``
```
https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
> Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753759296
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
```suggestion
"""Retrieves run state of the run.
Please note that any Airflow tasks that call the `get_run_state`
```
https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
> Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description.
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
Also restructuredText requires code to use double ticks, not single.
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
```suggestion
"""Retrieves run state of the run.
Please note that any Airflow tasks that call the ``get_run_state``
```
https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
> Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description.
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
Also restructuredText requires code to use double ticks, not single. Please fix all the code blocks below as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r754009718
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -34,6 +34,8 @@
from airflow.exceptions import AirflowException
from airflow.hooks.base import BaseHook
+RUN_STATE_FORMAT_STRING = "State: {}. Result: {}. {}"
Review comment:
I think having to change two places is actually kind of a good thing here, since it avoids the string to be accidentally changed—the test failures would notify us the change might be accidental.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r755026459
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -419,6 +427,46 @@ def get_run_state(self, run_id: str) -> RunState:
state_message = state['state_message']
return RunState(life_cycle_state, result_state, state_message)
+ def get_run_state_str(self, run_id: str) -> str:
+ """
+ Returns string representation of RunState
Review comment:
```suggestion
Return the string representation of RunState.
```
Examples: https://www.python.org/dev/peps/pep-0257/#one-line-docstrings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753759296
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
```suggestion
"""Retrieves run state of the run.
Please note that any Airflow tasks that call the `get_run_state`
```
https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings
> Multi-line docstrings consist of a summary line just like a one-line docstring, followed by a blank line, followed by a more elaborate description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753759320
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
Also restructuredText requires code to use double ticks, not single. Please fix all the code blocks below as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexott commented on a change in pull request #19723: Databricks: add more methods to represent run state information
Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #19723:
URL: https://github.com/apache/airflow/pull/19723#discussion_r753763623
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -400,7 +402,13 @@ def get_job_id(self, run_id: str) -> str:
def get_run_state(self, run_id: str) -> RunState:
"""
- Retrieves run state of the run.
+ Retrieves run state of the run. Please note that any Airflow tasks that call the `get_run_state`
Review comment:
thank you for review, addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org