You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/06 12:45:52 UTC

[GitHub] [airflow] RickRen7575 commented on pull request #18615: fix template string passed to env_vars when using render_template_as_native_obj for Kubernetes Pod Operator and add Tests

RickRen7575 commented on pull request #18615:
URL: https://github.com/apache/airflow/pull/18615#issuecomment-936168221


   > My main concern here is that `env_vars` intentionally takes `List[V1EnvVar]` - taking a `dict` is currently for backward compatibility only at this point. It's not that we couldn't support this, but there was a conscious move to using the models from the k8s client.
   
   Passing in a `List[V1EnvVar]` also doesn't work for the same reason. If we just set it up so that `List[V1EnvVar]` could work with this, that would be great as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org