[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #7140: [Fix-7037][dolphincheduler-server] process instance can not be killed when complement data

[GitBox <gi...@apache.org>]

caishunfeng commented on a change in pull request #7140:
URL: https://github.com/apache/dolphinscheduler/pull/7140#discussion_r762432788



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -518,7 +518,7 @@ public TaskInstance getTaskInstance(int taskInstanceId) {
     private boolean processStateChangeHandler(StateEvent stateEvent) {
         try {
             logger.info("process:{} state {} change to {}", processInstance.getId(), processInstance.getState(), stateEvent.getExecutionStatus());
-            if (processComplementData()) {
+            if (processInstance.getState() != ExecutionStatus.READY_STOP && processComplementData()) {

Review comment:
       Is it better to move this state condition into `processComplementData()`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org