You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2015/03/28 13:16:14 UTC
[GitHub] spark pull request: [SPARK-6586][SQL] Add the capability of retrie...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/5241
[SPARK-6586][SQL] Add the capability of retrieving original logical plan of DataFrame
In order to solve a bug, since #5217, `DataFrame` now uses analyzed plan instead of logical plan. However, by doing that we can't know the logical plan of a `DataFrame`. But it might be still useful and important to retrieve the original logical plan in some use cases.
In this pr, we introduce the capability of retrieving original logical plan of `DataFrame`.
The approach is that we add an `analyzed` variable to `LogicalPlan`. Once `Analyzer` finishes analysis, it sets `analyzed` of `LogicalPlan` as `true`. In `QueryExecution`, we keep the original logical plan in the analyzed plan. In `LogicalPlan`, a method `originalPlan` is added to recursively replace the analyzed logical plan with original logical plan and retrieve it.
Besides the capability of retrieving original logical plan, this modification also can avoid do plan analysis if it is already analyzed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 df_originalPlan
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5241.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5241
----
commit ee1d790b7488135a71db25babe3a7b5ecf3c13ee
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2015-03-28T11:58:02Z
Add the function to check if a logical plan is analyzed or not and retrieve original plan from DataFrame.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6586][SQL] Add the capability of retrie...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5241#issuecomment-87230784
[Test build #29348 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29348/consoleFull) for PR 5241 at commit [`ee1d790`](https://github.com/apache/spark/commit/ee1d790b7488135a71db25babe3a7b5ecf3c13ee).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6586][SQL] Add the capability of retrie...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/5241#issuecomment-87557379
Currently the option on jira is we don't need this capability to retrieve original plan for an analyzed plan. So I close this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6586][SQL] Add the capability of retrie...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5241#issuecomment-87217805
[Test build #29348 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29348/consoleFull) for PR 5241 at commit [`ee1d790`](https://github.com/apache/spark/commit/ee1d790b7488135a71db25babe3a7b5ecf3c13ee).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6586][SQL] Add the capability of retrie...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5241#issuecomment-87230804
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29348/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6586][SQL] Add the capability of retrie...
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/5241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org