You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "rpuch (via GitHub)" <gi...@apache.org> on 2024/11/22 07:26:28 UTC
[PR] IGNITE-23630 Store catalog object IDs as varints [ignite-3]
rpuch opened a new pull request, #4777:
URL: https://github.com/apache/ignite-3/pull/4777
https://issues.apache.org/jira/browse/IGNITE-23630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23630 Store catalog object IDs as varints [ignite-3]
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on PR #4777:
URL: https://github.com/apache/ignite-3/pull/4777#issuecomment-2493847568
Why don't just let DataOutput implementation take care of compressing numerics in writeInt/writeLong method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23630 Store catalog object IDs as varints [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch merged PR #4777:
URL: https://github.com/apache/ignite-3/pull/4777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23630 Store catalog object IDs as varints [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on PR #4777:
URL: https://github.com/apache/ignite-3/pull/4777#issuecomment-2493892093
> Does it make sense to write updateToken as VarInt ? Can we be sure it never be a kind of timestamp or large value?
I'm not sure, I was looking at the current situation. Are there any known plans of switching tokens from revisions to something (probably, less suitable for varints)? I'm not sure whether we should stick to varints here, to be honest, as they are used scarcely. If you believe just `long` is safer, let me know, I will change it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-23630 Store catalog object IDs as varints [ignite-3]
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on PR #4777:
URL: https://github.com/apache/ignite-3/pull/4777#issuecomment-2493884524
> Why don't just let DataOutput implementation take care of compressing numerics in writeInt/writeLong method?
Not for every int/long does it make sense to write them as a varint. For example, our varints are only space-effective for n >= -1, and for most negative values they are worse than regular ints. Also, if a field is not guaranteed to contain a small value most of the time (which is true for collection lengths and ordinals, like table IDs), regular ints/longs might be better. So it seems that the programmer should decide whether to use a regular int or a varint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org