You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/11/22 02:43:05 UTC
Review Request 28363: Added an overload for protobuf install.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28363/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Needed for subsequent review.
Diffs
-----
3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
Diff: https://reviews.apache.org/r/28363/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 28363: Added an overload for protobuf install.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28363/#review62805
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 22, 2014, 1:43 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28363/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2014, 1:43 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed for subsequent review.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
>
> Diff: https://reviews.apache.org/r/28363/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 28363: Added an overload for protobuf install.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28363/#review63400
-----------------------------------------------------------
3rdparty/libprocess/include/process/protobuf.hpp
<https://reviews.apache.org/r/28363/#comment105648>
unique_ptr please
3rdparty/libprocess/include/process/protobuf.hpp
<https://reviews.apache.org/r/28363/#comment105649>
unique_ptr please
- Dominic Hamon
On Nov. 24, 2014, 11:34 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28363/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 11:34 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed for subsequent review.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
>
> Diff: https://reviews.apache.org/r/28363/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 28363: Added an overload for protobuf install.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28363/#review63581
-----------------------------------------------------------
Ship it!
Had to fix the 80+ line length style issues introduced, I accidentally forgot to set the author field when doing that, apologies!
- Ben Mahler
On Nov. 24, 2014, 7:34 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28363/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 7:34 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Needed for subsequent review.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
>
> Diff: https://reviews.apache.org/r/28363/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 28363: Added an overload for protobuf install.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28363/
-----------------------------------------------------------
(Updated Nov. 24, 2014, 7:34 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
updated 'depends on'. NNFR.
Repository: mesos-git
Description
-------
Needed for subsequent review.
Diffs (updated)
-----
3rdparty/libprocess/include/process/protobuf.hpp f3fc53985847a4c610fd63c91492619f0c6b8720
Diff: https://reviews.apache.org/r/28363/diff/
Testing
-------
make check
Thanks,
Vinod Kone