You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/27 03:00:55 UTC

[GitHub] [spark] zhengruifeng commented on a change in pull request #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3

zhengruifeng commented on a change in pull request #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in Spark 3
URL: https://github.com/apache/spark/pull/22921#discussion_r384889410
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala
 ##########
 @@ -281,9 +265,6 @@ class GeneralMLWriter(stage: PipelineStage) extends MLWriter with Logging {
 
   // override for Java compatibility
   override def session(sparkSession: SparkSession): this.type = super.session(sparkSession)
-
-  // override for Java compatibility
-  override def context(sqlContext: SQLContext): this.type = super.session(sqlContext.sparkSession)
 
 Review comment:
   I never use this method, just check it. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org