[jira] [Commented] (AMQ-4814) Memory leak when unsubscribing durable consumer

["Claus Ibsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951853#comment-13951853 ] 

Claus Ibsen commented on AMQ-4814:
----------------------------------

Thanks for the patch. It does needs review, so lets see what [~gtully] or Tim has to say.

> Memory leak when unsubscribing durable consumer
> -----------------------------------------------
>
>                 Key: AMQ-4814
>                 URL: https://issues.apache.org/jira/browse/AMQ-4814
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.8.0
>            Reporter: jok
>              Labels: broker, durable_subscription, memory_leak
>             Fix For: NEEDS_REVIEW
>
>         Attachments: DurableSubscriberLeakDemo.java, StoreDurableSubscriberCursor.diff
>
>
> When creating and closing durable subscribers, references to FilePendingMessageCursor in MemoryUsage.listeners are not cleaned up.
> The reason seems to be a missing call to FilePendingMessageCursor.destroy() in StoreDurableSubscriberCursor.stop().
> A simple demo to reproduce the issue is attached (the leak is clearly visible after a few hundred to thousand runs). Also, i have attached a patch which resolves this issue for me - could someone check if this is correct?



--
This message was sent by Atlassian JIRA
(v6.2#6252)