You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2021/02/08 16:24:37 UTC
[GitHub] [tika] peterkronenberg opened a new pull request #403: Allow tesseract/tessdata path to be specified by environment variables
peterkronenberg opened a new pull request #403:
URL: https://github.com/apache/tika/pull/403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] lfcnassif commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
lfcnassif commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-775311928
Yes, inverting the logic, if tesseractPath (or tessdataPath) has the default empty value, env var would be used if set. If properties are specified, it will keep past behaviour too. I'm thinking about different apps in the same system using Tika, but with different configurations. Inverting the logic, it will not be an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] peterkronenberg commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
peterkronenberg commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-775332643
I think that's what it's already doing. If you don't specify it in the config and it is specified in the environment, it will use the environment values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] peterkronenberg commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
peterkronenberg commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-775348619
I just want to make sure that it doesn't break anything or have any unexpected behavior. Let me try it your way and see how it works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] peterkronenberg commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
peterkronenberg commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-775298403
Hi, not sure I follow. Are you saying TesseractConfig should override? If the environment variable isn't set, then it will have the same behavior as before. If you specify the env variables, than they will override
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] peterkronenberg closed pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
peterkronenberg closed pull request #403:
URL: https://github.com/apache/tika/pull/403
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] lfcnassif commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
lfcnassif commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-775282694
I think this logic should be inverted to use ENV var if property or tesseractConfig object is not set in context. So global system configuration could be overridden by app specific configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] peterkronenberg commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
peterkronenberg commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-775334365
So I think what you're saying is that even if environment variables are specified, then still use the config by default. And only if config is blank, then use environment ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] lfcnassif commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
lfcnassif commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-775340808
> So I think what you're saying is that even if environment variables are specified, then still use the config by default. And only if config is blank, then use environment ?
Yes that was my suggestion. Other commiter can have other opinion of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tika] peterkronenberg commented on pull request #403: Allow tesseract/tessdata path to be specified by environment variables
Posted by GitBox <gi...@apache.org>.
peterkronenberg commented on pull request #403:
URL: https://github.com/apache/tika/pull/403#issuecomment-776414822
Overtaken by events
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org