You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/03/31 09:38:11 UTC
Re: Review Request 57999: Made Path and Mount root optional in
Resource.DiskInfo.Source.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57999/
-----------------------------------------------------------
(Updated March 31, 2017, 11:38 a.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Improved output, per Jan.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
This commit is preparation for future changes where path or mount
roots might be calculated lazily, i.e., not known early enough
anymore.
Diffs (updated)
-----
include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633
src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
Diff: https://reviews.apache.org/r/57999/diff/3/
Changes: https://reviews.apache.org/r/57999/diff/2-3/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 57999: Made Path and Mount root optional in
Resource.DiskInfo.Source.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On April 3, 2017, 10:58 a.m., Jan Schlicht wrote:
> > src/common/resources.cpp
> > Lines 119 (patched)
> > <https://reviews.apache.org/r/57999/diff/3/?file=1681851#file1681851line119>
> >
> > RHS also needs to be checked for `root`.
> > `left.has_root() && right.has_root() && left.root() != right.root()`
Oh, seems that this is implicityly validated by the `left.has_root() != right.has_root()` above. Dropping this.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57999/#review170827
-----------------------------------------------------------
On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57999/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 11:38 a.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit is preparation for future changes where path or mount
> roots might be calculated lazily, i.e., not known early enough
> anymore.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
> src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/57999/diff/3/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 57999: Made Path and Mount root optional in
Resource.DiskInfo.Source.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57999/#review170827
-----------------------------------------------------------
src/common/resources.cpp
Lines 119 (patched)
<https://reviews.apache.org/r/57999/#comment243698>
RHS also needs to be checked for `root`.
`left.has_root() && right.has_root() && left.root() != right.root()`
src/common/resources.cpp
Lines 135 (patched)
<https://reviews.apache.org/r/57999/#comment243699>
See above.
src/slave/slave.cpp
Lines 385 (patched)
<https://reviews.apache.org/r/57999/#comment243702>
Let's add a line break before `<<` to reduce jaggedness, like most of these `EXIT(EXIT_FAILURE)` calls do in `Slave::initialize`.
src/slave/slave.cpp
Lines 403 (patched)
<https://reviews.apache.org/r/57999/#comment243703>
See above.
src/v1/resources.cpp
Lines 121 (patched)
<https://reviews.apache.org/r/57999/#comment243700>
See above, also check `right.has_root()`.
src/v1/resources.cpp
Lines 137 (patched)
<https://reviews.apache.org/r/57999/#comment243701>
See above.
- Jan Schlicht
On March 31, 2017, 11:38 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57999/
> -----------------------------------------------------------
>
> (Updated March 31, 2017, 11:38 a.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit is preparation for future changes where path or mount
> roots might be calculated lazily, i.e., not known early enough
> anymore.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
> src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/57999/diff/3/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 57999: Made Path and Mount root optional in
Resource.DiskInfo.Source.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57999/#review170840
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On April 3, 2017, 11:31 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57999/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 11:31 a.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit is preparation for future changes where path or mount
> roots might be calculated lazily, i.e., not known early enough
> anymore.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
> src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/57999/diff/4/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 57999: Made Path and Mount root optional in
Resource.DiskInfo.Source.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57999/#review171969
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 5, 2017, 1:56 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57999/
> -----------------------------------------------------------
>
> (Updated April 5, 2017, 1:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7312
> https://issues.apache.org/jira/browse/MESOS-7312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit is preparation for future changes where path or mount
> roots might be calculated lazily, i.e., not known early enough
> anymore.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
> include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
> src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
> src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
> src/slave/slave.cpp 65e4a67888fe908e5b2f6ca2ecc9e3a5b9958b2e
> src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
>
>
> Diff: https://reviews.apache.org/r/57999/diff/5/
>
>
> Testing
> -------
>
> make check (OS X, Fedora25)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 57999: Made Path and Mount root optional in
Resource.DiskInfo.Source.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57999/
-----------------------------------------------------------
(Updated April 5, 2017, 3:56 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Rebased.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
This commit is preparation for future changes where path or mount
roots might be calculated lazily, i.e., not known early enough
anymore.
Diffs (updated)
-----
include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f
src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
src/slave/slave.cpp 65e4a67888fe908e5b2f6ca2ecc9e3a5b9958b2e
src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
Diff: https://reviews.apache.org/r/57999/diff/5/
Changes: https://reviews.apache.org/r/57999/diff/4-5/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier
Re: Review Request 57999: Made Path and Mount root optional in
Resource.DiskInfo.Source.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57999/
-----------------------------------------------------------
(Updated April 3, 2017, 11:31 a.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Improved "jaggedness", per Jan's comment.
Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312
Repository: mesos
Description
-------
This commit is preparation for future changes where path or mount
roots might be calculated lazily, i.e., not known early enough
anymore.
Diffs (updated)
-----
include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac
include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c
src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a
src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f
src/slave/slave.cpp 1c164c9d2e22868ddec80d26a31504333f483633
src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11
Diff: https://reviews.apache.org/r/57999/diff/4/
Changes: https://reviews.apache.org/r/57999/diff/3-4/
Testing
-------
make check (OS X, Fedora25)
Thanks,
Benjamin Bannier