[GitHub] [hive] akshat0395 commented on a diff in pull request #4366: HIVE-27386: Avoid duplicate audit log in cleanupHandlerContext

["akshat0395 (via GitHub)" <gi...@apache.org>]

akshat0395 commented on code in PR #4366:
URL: https://github.com/apache/hive/pull/4366#discussion_r1211172194


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -182,8 +182,11 @@ static void cleanupHandlerContext() {
       HMSHandlerContext.getHMSHandler().ifPresent(handler -> {
         handler.notifyMetaListenersOnShutDown();
       });
-      HMSHandlerContext.clear();
-      logAndAudit("Done cleaning up thread local RawStore");
+      HMSHandlerContext.getRawStore().ifPresent(rs -> {
+        logAndAudit("Done cleaning up thread local RawStore");

Review Comment:
   This log should be printed after `HMSHandlerContext.clear()`, Once the clean up is done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org