You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/17 10:36:04 UTC
[GitHub] [flink-table-store] LadyForest opened a new pull request, #386: [FLINK-30071] Throw exception at compile time when sequence field does not exist
LadyForest opened a new pull request, #386:
URL: https://github.com/apache/flink-table-store/pull/386
This trivial improvement performs the sequence field existence check at compile time rather than runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #386: [FLINK-30071] Throw exception at compile time when sequence field does not exist
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #386:
URL: https://github.com/apache/flink-table-store/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #386: [FLINK-30071] Throw exception at compile time when sequence field does not exist
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #386:
URL: https://github.com/apache/flink-table-store/pull/386#discussion_r1025060627
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/ChangelogWithKeyFileStoreTable.java:
##########
@@ -77,6 +78,11 @@ public class ChangelogWithKeyFileStoreTable extends AbstractFileStoreTable {
for (int i = 0; i < fieldTypes.size(); i++) {
fieldGetters[i] = RowDataUtils.createNullCheckingFieldGetter(fieldTypes.get(i), i);
}
+ String sequenceField = conf.get(CoreOptions.SEQUENCE_FIELD);
Review Comment:
Maybe we can add this check in `SchemaManager.commit`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org