[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2748: Log error in Admin for no servers

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2748:
URL: https://github.com/apache/accumulo/pull/2748#discussion_r887163024


##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -115,7 +115,7 @@ static class StopManagerCommand {}
   @Parameters(commandDescription = "stop the master (DEPRECATED -- use stopManager instead)")
   static class StopMasterCommand {}
 
-  @Parameters(commandDescription = "stop all the servers")
+  @Parameters(commandDescription = "stop all of the tablets servers and manager")

Review Comment:
   @milleruntime Do you know if this stops the accumulo-gc and accumulo-monitor, or any of the compactor services? I would expect it to stop everything, including those, but based on the description you changed it to, I get the impression it doesn't.
   
   If it only stops the manager and tservers, I would like to commit my additional wording changes, but if it does stop those other servers, then the change you made should be rolled back instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org