[jira] [Comment Edited] (FLINK-12536) Make BufferOrEventSequence#getNext() non-blocking

["Piotr Nowojski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-12536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877759#comment-16877759 ] 

Piotr Nowojski edited comment on FLINK-12536 at 7/3/19 11:27 AM:
-----------------------------------------------------------------

With [~StephanEwen] we think that we should postpone the resolution of this ticket until we decide what to do with non credit based flow control.


was (Author: pnowojski):
With [~StephanEwen] we decided to postpone the resolution of this ticket until we decide what to do with non credit based flow control.

> Make BufferOrEventSequence#getNext() non-blocking
> -------------------------------------------------
>
>                 Key: FLINK-12536
>                 URL: https://issues.apache.org/jira/browse/FLINK-12536
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Network
>    Affects Versions: 1.9.0
>            Reporter: Piotr Nowojski
>            Assignee: Congxian Qiu(klion26)
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently it is non-blocking in case of credit-based flow control (default), however for \{{SpilledBufferOrEventSequence}} it is blocking on reading from file. We might want to consider reimplementing it to be non blocking with {{CompletableFuture<?> isAvailable()}} method.
>  
> Otherwise we will block mailbox processing for the duration of reading from file - for example we will block processing time timers and potentially in the future network flushes.
>  
> This is not a high priority change, since it affects non-default configuration option AND at the moment only processing time timers are planned to be moved to the mailbox for 1.9.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)