You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/07 14:23:11 UTC
[GitHub] [cloudstack-documentation] andrijapanicsb opened a new pull request #120: remove-environment.properties-note
andrijapanicsb opened a new pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120
The starting premise "if it doesn't exist" is impossible in the first place... (tested on 4.11.0 - agent will never connect if that line is missing in the file) - then no need to the warning/message - so removing it from 4.11+ Upgrade pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625704965
As I wrote... its impossible for that line to be missing in ACS 4.11+ (tested) as the agent would not connect to mgmt in the first place - so there is no reason to even have this premise that it MIGHT be missing in the first place - it can't be missing.
With that logic, we could ask users to check any lines in various files. See my point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625291048
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr120
Build Log Output:
No log errors found to report.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625823110
ah 👍 than
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625289803
requesting docbuild
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625820008
This was added back in the days of i.e. 4.5 or 4.6, etc, when it was supposed to be added once and it would stay there for the lifetime of that linux box.
If you have i.e. 4.11 installation, that means either a clean install (line already there) or someone upgraded from earlier version to 4.11 following the docs that say to add that line (line already there/already added).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
ACSGitBot commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625289854
Your request had been received, i'll go and build the documentation and check the output log for errors.
This shouldn't take long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625717776
ok, so is this a remark added for trouble shooting?
I see your point but also this was added to help some users (actually to prevent questions). Is that no longer valid or should it maybe be moved to a trouble shooting section instead of deleted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #120: remove-environment.properties-note
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #120:
URL: https://github.com/apache/cloudstack-documentation/pull/120#issuecomment-625688121
> The starting premise "if it doesn't exist" is impossible in the first place... (tested on 4.11.0 - agent will never connect if that line is missing in the file) - then no need to the warning/message - so removing it from 4.11+ Upgrade pages.
I don't see how this is a reason to remove this line. Users need to be attended to adding it, right? How is it impossible that a line is missing from a conf file? (unless we are adding it in automated fashion.
Should
```
paths.script=/usr/share/cloudstack-common
```
be in `/etc/cloudstack/agent/environment.properties`, than i see no reason for this removal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org