You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by st...@apache.org on 2017/02/09 10:26:43 UTC

svn commit: r1782304 - /jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationTest.java

Author: stefanegli
Date: Thu Feb  9 10:26:43 2017
New Revision: 1782304

URL: http://svn.apache.org/viewvc?rev=1782304&view=rev
Log:
OAK-5619 : adding a currently disabled test case to reproduce this

Modified:
    jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationTest.java

Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationTest.java?rev=1782304&r1=1782303&r2=1782304&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationTest.java Thu Feb  9 10:26:43 2017
@@ -107,6 +107,7 @@ import org.apache.jackrabbit.oak.plugins
 import org.apache.jackrabbit.oak.plugins.observation.filter.Selectors;
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -1539,6 +1540,54 @@ public class ObservationTest extends Abs
         testNode.getNode("a").remove();
         testNode.getSession().save();
     }
+    
+    /**
+     * This tests a filter which registers a few paths and then expects
+     * NOT to get any event if an unrelated parent is removed
+     */
+    @Test
+    @Ignore("OAK-5619")
+    public void includeAncestorsRemove_Unrelated() throws Exception {
+        assumeTrue(observationManager instanceof ObservationManagerImpl);
+        ObservationManagerImpl oManager = (ObservationManagerImpl) observationManager;
+
+        // [/conf/global/settings/granite/operations/maintenance, /libs/settings/granite/operations/maintenance, /apps/settings/granite/operations/maintenance]
+        JackrabbitEventFilter filterWithAncestorsRemove = new JackrabbitEventFilter();
+        filterWithAncestorsRemove.setEventTypes(ALL_EVENTS);
+        filterWithAncestorsRemove.setAbsPath(TEST_PATH + "/a/b/c/d");
+        filterWithAncestorsRemove.setIsDeep(true);
+        filterWithAncestorsRemove = FilterFactory.wrap(filterWithAncestorsRemove).withIncludeAncestorsRemove();
+        ExpectationListener listenerWithAncestorsRemove = new ExpectationListener();
+        oManager.addEventListener(listenerWithAncestorsRemove, filterWithAncestorsRemove);
+
+        JackrabbitEventFilter filterWithoutAncestorsRemove = new JackrabbitEventFilter();
+        filterWithoutAncestorsRemove.setEventTypes(ALL_EVENTS);
+        filterWithoutAncestorsRemove.setAbsPath(TEST_PATH + "/a/b/c/d");
+        filterWithoutAncestorsRemove.setIsDeep(true);
+        ExpectationListener listenerWithoutAncestorsRemove = new ExpectationListener();
+        oManager.addEventListener(listenerWithoutAncestorsRemove, filterWithoutAncestorsRemove);
+
+        Session session = getAdminSession();
+        session.getRootNode().addNode("unrelated");
+        session.save();
+
+        session.getRootNode().getNode("unrelated").remove();
+        Node testNode = session.getRootNode().getNode(TEST_NODE);
+        listenerWithAncestorsRemove.expect(testNode.getPath(), NODE_REMOVED);
+        testNode.remove();
+        session.save();
+        
+        Thread.sleep(1000);
+        List<Expectation> missing = listenerWithoutAncestorsRemove.getMissing(TIME_OUT, TimeUnit.SECONDS);
+        List<Event> unexpected = listenerWithoutAncestorsRemove.getUnexpected();
+        assertTrue("Unexpected events: " + unexpected, unexpected.isEmpty());
+        assertTrue("Missing events: " + missing, missing.isEmpty());
+
+        missing = listenerWithAncestorsRemove.getMissing(TIME_OUT, TimeUnit.SECONDS);
+        unexpected = listenerWithAncestorsRemove.getUnexpected();
+        assertTrue("Unexpected events: " + unexpected, unexpected.isEmpty());
+        assertTrue("Missing events: " + missing, missing.isEmpty());
+    }
 
     @Test
     public void includeAncestorsRemove() throws Exception {