[GitHub] [incubator-kyuubi] cxzl25 commented on a change in pull request #2113: [KYUUBI #2112] Improve the compatibility of queryTimeout in more version clients

[GitBox <gi...@apache.org>]

cxzl25 commented on a change in pull request #2113:
URL: https://github.com/apache/incubator-kyuubi/pull/2113#discussion_r825596925



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/operation/ExecuteStatement.scala
##########
@@ -125,7 +144,17 @@ class ExecuteStatement(
             setState(OperationState.CANCELED)
 
           case TIMEDOUT_STATE =>
-            setState(OperationState.TIMEOUT)
+            val state =
+              if (operationQueryTimeoutCompatibleState) {
+                if (queryTimeout > 0) {

Review comment:
       It was considered before that the server has enabled `queryTimeout`, but although the client supports this feature, `queryTimeout` is not set.
   Now change it a little easier, turn it on and convert it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org