You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2025/05/17 03:46:49 UTC
(spark-kubernetes-operator) branch main updated: [SPARK-52201] Revisit `PMD` annotations
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/spark-kubernetes-operator.git
The following commit(s) were added to refs/heads/main by this push:
new 2d569b6 [SPARK-52201] Revisit `PMD` annotations
2d569b6 is described below
commit 2d569b61d7c0f1c5205820315edd6f6e8e07c6af
Author: Dongjoon Hyun <do...@apache.org>
AuthorDate: Fri May 16 20:46:39 2025 -0700
[SPARK-52201] Revisit `PMD` annotations
### What changes were proposed in this pull request?
This PR aims to revisit `PMD` annotations.
### Why are the changes needed?
We can remove or reduce the scope.
**BEFORE**
```
$ git grep PMD | wc -l
5
```
**AFTER**
```
$ git grep PMD | wc -l
3
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #210 from dongjoon-hyun/SPARK-52201.
Authored-by: Dongjoon Hyun <do...@apache.org>
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
config/pmd/ruleset.xml | 1 -
.../test/java/org/apache/spark/k8s/operator/metrics/sink/MockSink.java | 2 +-
.../k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java | 1 -
.../test/java/org/apache/spark/k8s/operator/probe/ProbeServiceTest.java | 2 +-
.../java/org/apache/spark/k8s/operator/probe/ReadinessProbeTest.java | 2 +-
.../spark/k8s/operator/reconciler/reconcilesteps/AppInitStepTest.java | 1 -
6 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/config/pmd/ruleset.xml b/config/pmd/ruleset.xml
index 0f97d1b..a947ab5 100644
--- a/config/pmd/ruleset.xml
+++ b/config/pmd/ruleset.xml
@@ -26,7 +26,6 @@
<exclude name="ImplicitFunctionalInterface" />
<exclude name="UnitTestAssertionsShouldIncludeMessage" />
<exclude name="UnitTestContainsTooManyAsserts" />
- <exclude name="UnitTestShouldIncludeAssert" />
<exclude name="UnusedLocalVariable" />
<exclude name="LooseCoupling" />
</rule>
diff --git a/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/sink/MockSink.java b/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/sink/MockSink.java
index 145652c..67e366f 100644
--- a/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/sink/MockSink.java
+++ b/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/sink/MockSink.java
@@ -28,7 +28,7 @@ import org.slf4j.LoggerFactory;
import org.apache.spark.metrics.sink.Sink;
-@SuppressWarnings("PMD")
+@SuppressWarnings("PMD.UnusedPrivateField")
public class MockSink implements Sink {
private static final Logger logger = LoggerFactory.getLogger(MockSink.class);
private final Properties properties;
diff --git a/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java b/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java
index a1d9665..9217f44 100644
--- a/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java
+++ b/spark-operator/src/test/java/org/apache/spark/k8s/operator/metrics/source/KubernetesMetricsInterceptorTest.java
@@ -49,7 +49,6 @@ import org.apache.spark.k8s.operator.spec.ApplicationSpec;
@EnableKubernetesMockClient(crud = true)
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
-@SuppressWarnings("PMD")
@SuppressFBWarnings(
value = {"UWF_UNWRITTEN_FIELD", "NP_UNWRITTEN_FIELD", "UUF_UNUSED_FIELD"},
justification = "Unwritten fields are covered by Kubernetes mock client")
diff --git a/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ProbeServiceTest.java b/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ProbeServiceTest.java
index 1e1bdd6..da221c3 100644
--- a/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ProbeServiceTest.java
+++ b/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ProbeServiceTest.java
@@ -43,7 +43,7 @@ import org.junit.jupiter.api.Test;
import org.apache.spark.k8s.operator.metrics.healthcheck.SentinelManager;
-@SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert")
+@SuppressWarnings("PMD.UnitTestShouldIncludeAssert")
@EnableKubernetesMockClient
class ProbeServiceTest {
@Test
diff --git a/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ReadinessProbeTest.java b/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ReadinessProbeTest.java
index e8a0850..4579afe 100644
--- a/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ReadinessProbeTest.java
+++ b/spark-operator/src/test/java/org/apache/spark/k8s/operator/probe/ReadinessProbeTest.java
@@ -37,7 +37,7 @@ import org.mockito.Mockito;
import org.apache.spark.k8s.operator.utils.ProbeUtil;
-@SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert")
+@SuppressWarnings("PMD.UnitTestShouldIncludeAssert")
class ReadinessProbeTest {
KubernetesClient client;
HttpExchange httpExchange;
diff --git a/spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppInitStepTest.java b/spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppInitStepTest.java
index f51dabe..6495b71 100644
--- a/spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppInitStepTest.java
+++ b/spark-operator/src/test/java/org/apache/spark/k8s/operator/reconciler/reconcilesteps/AppInitStepTest.java
@@ -52,7 +52,6 @@ import org.apache.spark.k8s.operator.context.SparkAppContext;
import org.apache.spark.k8s.operator.utils.SparkAppStatusRecorder;
@EnableKubernetesMockClient(crud = true)
-@SuppressWarnings("PMD")
@SuppressFBWarnings(
value = {"UWF_UNWRITTEN_FIELD", "NP_UNWRITTEN_FIELD", "UUF_UNUSED_FIELD"},
justification = "Unwritten fields are covered by Kubernetes mock client")
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org