You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/08/23 07:53:07 UTC

[GitHub] activemq-artemis pull request #2262: ARTEMIS-1663 fix disparity on messageco...

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2262

    ARTEMIS-1663 fix disparity on messagecount

    Reverting a change done in 1663.
    
    It seems the new messagecount != the original messageReferences.size all the time, it is more reliable to use the original messageReferences size as this is the actual collection's size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis AREMIS1663-FIX

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2262
    
----
commit 2f9e30cde211950bf00cd9a00c05e09ae4dc6fea
Author: Michael André Pearce <mi...@...>
Date:   2018-08-23T07:50:34Z

    ARTEMIS-1663 fix disparity on messagecount
    
    Reverting a change done in 1663.
    
    It seems the new messagecount != the original messageReferences.size all the time, it is more reliable to use the original messageReferences size as this is the actual collection's size.

----


---

[GitHub] activemq-artemis pull request #2262: ARTEMIS-1663 fix disparity on messageco...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2262


---

[GitHub] activemq-artemis issue #2262: ARTEMIS-1663 fix disparity on messagecount

Posted by cshannon <gi...@git.apache.org>.

Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2262
  
    @michaelandrepearce - Do you have an actual use case or example where it's not reliable?  The new metric gets used for size stuff as well so I don't think it should be changed for consistency and should be fixed if there is an issue
    
    However I also see you closed this out so is there not actually an issue here?


---

[GitHub] activemq-artemis issue #2262: ARTEMIS-1663 fix disparity on messagecount

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2262
  
    @cshannon we have an issue where we have reported message count that never get dispatched, it was thought it was metric issue only, e.g. difference between whats in the messageferences and the counter (e.g. the messages aren't really there), but it looks like a more serious issue with the messages not being delivered for one reason or another and the messages really are in messageferences. They fun of a not very easy to replicate issue.


---