You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/17 17:03:06 UTC
[GitHub] [camel-k] haanhvu opened a new pull request, #3217: Make Types in Kamelet a struct type
haanhvu opened a new pull request, #3217:
URL: https://github.com/apache/camel-k/pull/3217
**Release Note**
```release-note
NONE
```
fixes #2818
@astefanutti @squakez can you please check if this is the right direction.
This PR is not done yet. Since I changed the types of Types and EventSlot, there's probably a lot of code, yaml, doc to be changed too.
But first, please help me check if this is the right direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] haanhvu commented on pull request #3217: Make Types in Kamelet a struct
Posted by GitBox <gi...@apache.org>.
haanhvu commented on PR #3217:
URL: https://github.com/apache/camel-k/pull/3217#issuecomment-1101268945
> I think it could be okey, but, as you said, we must fit this change within the rest of the source code. Also, I think we have a compatibility problem as we're trying to change the API spec within the same version. I'd defer this work when we move to `v1` version. Alternatively, we must make this change backward compatible, and, maintaining both new and old schema can be an hassle.
@squakez I understand.
I think we can think of changing the schema later.
For now, I think we can do a quick fix by providing an enum so that users can only insert out/in/error tag. Something like:
```
types:
additionalProperties:
properties:
mediaType:
...
schema:
...
type: object
enum:
- in
- out
- error
```
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3217: Make Types in Kamelet a struct
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3217:
URL: https://github.com/apache/camel-k/pull/3217#issuecomment-1101294469
The Custom Resource is autogenerated, so, whatever we do we need to change the source code. I see value in the definitive solution, therefore, deferring the development to a future new API version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] github-actions[bot] commented on pull request #3217: Make Types in Kamelet a struct
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3217:
URL: https://github.com/apache/camel-k/pull/3217#issuecomment-1250421571
This PR has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org