[GitHub] [spark] TJX2014 commented on a change in pull request #28291: [SPARK-31400][ML]The catalogString doesn't distinguish Vectors in ml and mllib

[GitBox <gi...@apache.org>]

TJX2014 commented on a change in pull request #28291:
URL: https://github.com/apache/spark/pull/28291#discussion_r413809914



##########
File path: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
##########
@@ -40,6 +40,8 @@ private[spark] object SchemaUtils {
       msg: String = ""): Unit = {
     val actualDataType = schema(colName).dataType
     val message = if (msg != null && msg.trim.length > 0) " " + msg else ""
+    require(actualDataType.getClass.getPackage.equals(dataType.getClass.getPackage),
+      s"Column $colName  of type ${dataType.typeName} must belong to ml package")

Review comment:
       Thanks for your review and advise, I will try to improve it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org