You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/07 15:37:21 UTC

[GitHub] [pulsar] merlimat opened a new pull request #11952: Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace

merlimat opened a new pull request #11952:
URL: https://github.com/apache/pulsar/pull/11952


   ### Motivation
   
   `ReplicatorTest.testRemoveClusterFromNamespace()` is flaky because it's trying to do: 
   
    1. Use `r4` as an alias cluster for `r3`
    2. Create a topic with replication to clusters `r1`, `r3` and `r4`
    3. Remove `r4` and check that the replicator got disconnected
   
   The problem is that the broker will try to get 2 replicators (for `r3` and `r4`) to the same broker instance, causing a "producer with same name is already connected" error). Depending on if the `r3` or `r4` replicator connects first, the test would succeed or fail.
   
   ### Modifications
   
    * Pulled the test in dedicated class
    * Use `r1`, `r2` and `r3` clusters, without aliasing
    * Delete `r3` cluster to prove the point
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #11952: Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #11952:
URL: https://github.com/apache/pulsar/pull/11952#issuecomment-1056727649


   it looks like this has been included in this commit https://github.com/apache/pulsar/commit/89841aaf82b16ac4dfe7b7839211b3b38d6320a4
   
   probably by mistake, I will send a pr for branch-2.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat closed pull request #11952: Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace

Posted by GitBox <gi...@apache.org>.
merlimat closed pull request #11952:
URL: https://github.com/apache/pulsar/pull/11952


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #11952: Fixed flaky test ReplicatorTest.testRemoveClusterFromNamespace

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #11952:
URL: https://github.com/apache/pulsar/pull/11952#issuecomment-1056723388


   @merlimat @eolivelli @lhotari can we port this fix to branch-2.8 ? 
   
   https://github.com/apache/pulsar/runs/5379426494?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org