You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2019/01/14 23:08:15 UTC

[beam] Diff for: [GitHub] chamikaramj merged pull request #7428: [BEAM-6391] add missing raise keywords

diff --git a/sdks/python/apache_beam/io/gcp/datastore/v1/datastoreio.py b/sdks/python/apache_beam/io/gcp/datastore/v1/datastoreio.py
index 66cca24f1936..123d063525b5 100644
--- a/sdks/python/apache_beam/io/gcp/datastore/v1/datastoreio.py
+++ b/sdks/python/apache_beam/io/gcp/datastore/v1/datastoreio.py
@@ -115,11 +115,11 @@ def __init__(self, project, query, namespace=None, num_splits=0):
     super(ReadFromDatastore, self).__init__()
 
     if not project:
-      ValueError("Project cannot be empty")
+      raise ValueError("Project cannot be empty")
     if not query:
-      ValueError("Query cannot be empty")
+      raise ValueError("Query cannot be empty")
     if num_splits < 0:
-      ValueError("num_splits must be greater than or equal 0")
+      raise ValueError("num_splits must be greater than or equal 0")
 
     self._project = project
     # using _namespace conflicts with DisplayData._namespace


With regards,
Apache Git Services