You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Erwan de FERRIERES (JIRA)" <ji...@apache.org> on 2011/03/10 15:19:59 UTC

[jira] Created: (OFBIZ-4211) [GSoC] code/test separation

[GSoC] code/test separation
---------------------------

                 Key: OFBIZ-4211
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
             Project: OFBiz
          Issue Type: Improvement
    Affects Versions: SVN trunk
            Reporter: Erwan de FERRIERES
            Priority: Minor


One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.

{code}
src/main/java	Application/Library sources
src/test/java	Test sources
{code}

http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Commented] (OFBIZ-4211) [GSoC] code/test separation

Posted by Ganath Rathnayaka <ga...@gmail.com>.
Thanks Erwan. I will follow them and commit the changes to the github.

[jira] Commented: (OFBIZ-4211) [GSoC] code/test separation

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007681#comment-13007681 ] 

Adrian Crum commented on OFBIZ-4211:
------------------------------------

GSOC participants should check out the latest code from the repository:

https://cwiki.apache.org/OFBADMIN/ofbiz-source-repository-and-access.html

You will notice that OFBiz is divided up into modules or "components" and each component is kept in its own folder. Within each folder there is a single Java source tree. The goal is to have two separate Java source trees within each component - one for deployment and one for testing. The deployment jars should not have test classes in them.

Create patches for your changes and attach them here - being sure to grant the ASF permission to include your work.For information on creating patches, read the "How to Send in Your Contributions" section here:

https://cwiki.apache.org/OFBADMIN/ofbiz-contributors-best-practices.html

Please keep discussions about this GSOC project in this Jira issue - that will make it easier for others to participate.



> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (OFBIZ-4211) [GSoC] code/test separation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005592#comment-13005592 ] 

Erwan de FERRIERES commented on OFBIZ-4211:
-------------------------------------------

no problem, I'm starting a thread right now.

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (OFBIZ-4211) [GSoC] code/test separation

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005079#comment-13005079 ] 

Adrian Crum commented on OFBIZ-4211:
------------------------------------

This has been discussed on the dev mailing list and there seems to be some disagreement about its benefits. Maybe this should be discussed on the dev mailing list before any work is done.

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4211) [GSoC] code/test separation

Posted by "Ganath Rathnayake (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041394#comment-13041394 ] 

Ganath Rathnayake commented on OFBIZ-4211:
------------------------------------------

Thanks Adrian, I'll fixed it.
Erwan,
I will commit the changes to the git-repo. Still I didn't figure how to set the public key and I am following your link on git hub to do it.
thanks

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>         Attachments: trees-tructures.zip, treeview.txt
>
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4211) [GSoC] code/test separation

Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041232#comment-13041232 ] 

Adrian Crum commented on OFBIZ-4211:
------------------------------------

In the accounting folder, the test branch is missing the "org" folder.


> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>         Attachments: trees-tructures.zip, treeview.txt
>
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4211) [GSoC] code/test separation

Posted by "Ganath Rathnayake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ganath Rathnayake updated OFBIZ-4211:
-------------------------------------

    Attachment: treeview.txt

Here am attaching the tree view of the current code and now we can discuss what need to be separated.

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>         Attachments: treeview.txt
>
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4211) [GSoC] code/test separation

Posted by "Ganath Rathnayake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ganath Rathnayake updated OFBIZ-4211:
-------------------------------------

    Attachment: trees-tructures.zip

This is the folder structure after I edit the git-repo I did not commit this to the git-repo since this cannot be build using existing build.xml. I will commit after I have edit the build.xml.
thanks

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>         Attachments: trees-tructures.zip, treeview.txt
>
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4211) [GSoC] code/test separation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041467#comment-13041467 ] 

Erwan de FERRIERES commented on OFBIZ-4211:
-------------------------------------------

Hi Ganath,

everything is here : http://help.github.com/linux-set-up-git/ and http://help.github.com/troubleshooting-ssh/

I found it well explained, it should help you !

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>         Attachments: trees-tructures.zip, treeview.txt
>
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OFBIZ-4211) [GSoC] code/test separation

Posted by "Erwan de FERRIERES (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041237#comment-13041237 ] 

Erwan de FERRIERES commented on OFBIZ-4211:
-------------------------------------------

Ganath,

you may commit directly in your git repo. These way we could also track your changes.
Adding new messages to this issue is a good practice, keep it this way !

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>         Attachments: trees-tructures.zip, treeview.txt
>
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OFBIZ-4211) [GSoC] code/test separation

Posted by "Ganath Rathnayake (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ganath Rathnayake updated OFBIZ-4211:
-------------------------------------

    Attachment: specialpurpose.out

Here is the new folder structure of the specialpurpose folder after test/code separation.

> [GSoC] code/test separation
> ---------------------------
>
>                 Key: OFBIZ-4211
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4211
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>              Labels: gsoc2011, mentor
>         Attachments: specialpurpose.out, trees-tructures.zip, treeview.txt
>
>
> One for the maven practices is to separate code and test code source. We are not using maven with OFBiz, but this separation can be beneficial.
> {code}
> src/main/java	Application/Library sources
> src/test/java	Test sources
> {code}
> http://stackoverflow.com/questions/2388253/separation-of-junit-classes-into-special-test-package

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira