You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/19 21:01:00 UTC

[jira] [Commented] (SAMZA-1414) SamzaContainer log statements incorrectly expect containerId is a number

    [ https://issues.apache.org/jira/browse/SAMZA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172338#comment-16172338 ] 

ASF GitHub Bot commented on SAMZA-1414:
---------------------------------------

GitHub user dnishimura opened a pull request:

    https://github.com/apache/samza/pull/298

    SAMZA-1414: SamzaContainer log statements incorrectly expect containerId is a number

    Correctly log ID as a string in SamzaContainer.
    @jmakes 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnishimura/samza samza-1414

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #298
    
----
commit d83cf3ab499a0ca339d2801a36ee18f2ddf15588
Author: Daniel Nishimura <dn...@gmail.com>
Date:   2017-09-19T20:53:00Z

    Correctly log ID as a string in SamzaContainer.

----


> SamzaContainer log statements incorrectly expect containerId is a number
> ------------------------------------------------------------------------
>
>                 Key: SAMZA-1414
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1414
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Jake Maes
>              Labels: newbie
>             Fix For: 0.14.0
>
>
> The line numbers wont match up with the latest, but here's a stack trace. 
> {noFormat}
> java.util.IllegalFormatConversionException: d != java.lang.String
>     at java.util.Formatter$FormatSpecifier.failConversion(Formatter.java:4302)
>     at java.util.Formatter$FormatSpecifier.printInteger(Formatter.java:2793)
>     at java.util.Formatter$FormatSpecifier.print(Formatter.java:2747)
>     at java.util.Formatter.format(Formatter.java:2520)
>     at java.util.Formatter.format(Formatter.java:2455)
>     at java.lang.String.format(String.java:2940)
>     at scala.collection.immutable.StringLike$class.format(StringLike.scala:266)
>     at scala.collection.immutable.StringOps.format(StringOps.scala:31)
>     at org.apache.samza.container.SamzaContainer$$anonfun$startLocalityManager$4.apply(SamzaContainer.scala:857)
>     at org.apache.samza.container.SamzaContainer$$anonfun$startLocalityManager$4.apply(SamzaContainer.scala:857)
>     at org.apache.samza.util.Logging$class.warn(Logging.scala:74)
>     at org.apache.samza.container.SamzaContainer.warn(SamzaContainer.scala:640)
>     at org.apache.samza.container.SamzaContainer.startLocalityManager(SamzaContainer.scala:856)
>     at org.apache.samza.container.SamzaContainer.run(SamzaContainer.scala:684)
>     at org.apache.samza.runtime.LocalContainerRunner.run(LocalContainerRunner.java:104)
>     at org.apache.samza.runtime.LocalContainerRunner.main(LocalContainerRunner.java:149)
> {noFormat}
> Looks like the log statements need to expect containerId as a string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)