You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/20 21:14:08 UTC
Review Request 35695: stout: Fixed test names.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository: mesos
Description
-------
First noticed `JsonTest.parse`, then found the other cases with the following regex: `TEST.*(.*, [a-z].*`.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 60c0336082caf30b2d7943d85ef3bb7a534648d8
3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp 4dbe4bab79f7536a6a7a53348f44f8ac888d3d1d
3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp f2386d55c658a5bbdedb6b433c70f7739f6ac0d4
3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a1677fb0bb92215e29f98a17c97d5309279c
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 62987e0df28f28816c59d7cbad89fa2af41ade04
3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp d3c9aede8e8a7f419f8eae7a7f52629d5cc1513f
3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12d7334b16496377f60b2e830401dd0db86
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986de72a51540ebeb56db7eb399fb8e66f87
Diff: https://reviews.apache.org/r/35695/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35695: stout: Fixed test names.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88841
-----------------------------------------------------------
Ship it!
Thanks, will commit this for you.
Ditto the previous question about the "Test" suffix, curious to hear your thoughts on it.
- Ben Mahler
On June 20, 2015, 7:14 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35695/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> First noticed `JsonTest.parse`, then found the other cases with the following regex: `TEST.*(.*, [a-z].*`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 60c0336082caf30b2d7943d85ef3bb7a534648d8
> 3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp 4dbe4bab79f7536a6a7a53348f44f8ac888d3d1d
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp f2386d55c658a5bbdedb6b433c70f7739f6ac0d4
> 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a1677fb0bb92215e29f98a17c97d5309279c
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 62987e0df28f28816c59d7cbad89fa2af41ade04
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp d3c9aede8e8a7f419f8eae7a7f52629d5cc1513f
> 3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12d7334b16496377f60b2e830401dd0db86
> 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986de72a51540ebeb56db7eb399fb8e66f87
>
> Diff: https://reviews.apache.org/r/35695/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35695: stout: Fixed test names.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88810
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On June 20, 2015, 7:14 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35695/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> First noticed `JsonTest.parse`, then found the other cases with the following regex: `TEST.*(.*, [a-z].*`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 60c0336082caf30b2d7943d85ef3bb7a534648d8
> 3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp 4dbe4bab79f7536a6a7a53348f44f8ac888d3d1d
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp f2386d55c658a5bbdedb6b433c70f7739f6ac0d4
> 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a1677fb0bb92215e29f98a17c97d5309279c
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 62987e0df28f28816c59d7cbad89fa2af41ade04
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp d3c9aede8e8a7f419f8eae7a7f52629d5cc1513f
> 3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12d7334b16496377f60b2e830401dd0db86
> 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986de72a51540ebeb56db7eb399fb8e66f87
>
> Diff: https://reviews.apache.org/r/35695/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35695: stout: Fixed test names.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88674
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35695]
All tests passed.
- Mesos ReviewBot
On June 20, 2015, 7:14 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35695/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> First noticed `JsonTest.parse`, then found the other cases with the following regex: `TEST.*(.*, [a-z].*`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 60c0336082caf30b2d7943d85ef3bb7a534648d8
> 3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp 4dbe4bab79f7536a6a7a53348f44f8ac888d3d1d
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp f2386d55c658a5bbdedb6b433c70f7739f6ac0d4
> 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a1677fb0bb92215e29f98a17c97d5309279c
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 62987e0df28f28816c59d7cbad89fa2af41ade04
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp d3c9aede8e8a7f419f8eae7a7f52629d5cc1513f
> 3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12d7334b16496377f60b2e830401dd0db86
> 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986de72a51540ebeb56db7eb399fb8e66f87
>
> Diff: https://reviews.apache.org/r/35695/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35695: stout: Fixed test names.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88680
-----------------------------------------------------------
Ship it!
Ship It!
- Marco Massenzio
On June 20, 2015, 7:14 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35695/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 7:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> First noticed `JsonTest.parse`, then found the other cases with the following regex: `TEST.*(.*, [a-z].*`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 60c0336082caf30b2d7943d85ef3bb7a534648d8
> 3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp 4dbe4bab79f7536a6a7a53348f44f8ac888d3d1d
> 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp f2386d55c658a5bbdedb6b433c70f7739f6ac0d4
> 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp ad79a1677fb0bb92215e29f98a17c97d5309279c
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 62987e0df28f28816c59d7cbad89fa2af41ade04
> 3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp d3c9aede8e8a7f419f8eae7a7f52629d5cc1513f
> 3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 7519b12d7334b16496377f60b2e830401dd0db86
> 3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp ad1d986de72a51540ebeb56db7eb399fb8e66f87
>
> Diff: https://reviews.apache.org/r/35695/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>