You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/06/30 17:47:55 UTC

[GitHub] [submarine] MortalHappiness opened a new pull request #628: SUBMARINE-831. Update the status of submarine custom resource in syncHandler

MortalHappiness opened a new pull request #628:
URL: https://github.com/apache/submarine/pull/628


   ### What is this PR for?
   Update the status of submarine custom resource in syncHandler so that we can see the status of the submarine custom resource.
   
   Reference: https://github.com/kubernetes/sample-controller/blob/73e81dab82c945b087f7db1f1f4a7b50e7d92751/controller.go#L321-L333
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-831
   
   ### How should this be tested?
   
   After running the operator and create the submarine custom resource, try to change the replicas of server and database in the spec. (See the following video)
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] kevin85421 commented on pull request #628: SUBMARINE-831. Update the status of submarine custom resource in syncHandler

Posted by GitBox <gi...@apache.org>.
kevin85421 commented on pull request #628:
URL: https://github.com/apache/submarine/pull/628#issuecomment-872687276


   @MortalHappiness Thank you for your contribution. Let me know if you resolve the conflict.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #628: SUBMARINE-831. Update the status of submarine custom resource in syncHandler

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #628:
URL: https://github.com/apache/submarine/pull/628#issuecomment-872791137


   @kevin85421 I have resolved the conflict. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #628: SUBMARINE-831. Update the status of submarine custom resource in syncHandler

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #628:
URL: https://github.com/apache/submarine/pull/628


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org