You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/09/10 04:52:27 UTC
[kudu-CR] KUDU-2671 update on partition-test
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17840
Change subject: KUDU-2671 update on partition-test
......................................................................
KUDU-2671 update on partition-test
This patch adds missing range- and partition-key checks
for the range partition with empty hash schema in the
PartitionTest.TestVaryingHashSchemasPerUnboundedRanges scenario.
This is a follow-up to 03451904a20123ca27eaa4e9773b94c0532fd342.
Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
---
M src/kudu/common/partition-test.cc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/17840/1
--
To view, visit http://gerrit.cloudera.org:8080/17840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
Gerrit-Change-Number: 17840
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2671 update on partition-test
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17840 )
Change subject: KUDU-2671 update on partition-test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
Gerrit-Change-Number: 17840
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 22:09:57 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 update on partition-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 update on partition-test
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
Gerrit-Change-Number: 17840
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 update on partition-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17840 )
Change subject: KUDU-2671 update on partition-test
......................................................................
Patch Set 1: Verified+1
unrelated test failure in RaftConsensusITest.TestSlowFollower
--
To view, visit http://gerrit.cloudera.org:8080/17840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
Gerrit-Change-Number: 17840
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 05:50:52 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 update on partition-test
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17840 )
Change subject: KUDU-2671 update on partition-test
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
Gerrit-Change-Number: 17840
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 06:42:32 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 update on partition-test
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17840 )
Change subject: KUDU-2671 update on partition-test
......................................................................
KUDU-2671 update on partition-test
This patch adds missing range- and partition-key checks
for the range partition with empty hash schema in the
PartitionTest.TestVaryingHashSchemasPerUnboundedRanges scenario.
This is a follow-up to 03451904a20123ca27eaa4e9773b94c0532fd342.
Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
Reviewed-on: http://gerrit.cloudera.org:8080/17840
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/common/partition-test.cc
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id93f92ab52ee3e8fb6bf3b74105333edcebe0461
Gerrit-Change-Number: 17840
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>