You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/01 01:23:14 UTC

[GitHub] [arrow] traversc opened a new pull request #8808: [R] minimum version for cpp11

traversc opened a new pull request #8808:
URL: https://github.com/apache/arrow/pull/8808


   R arrow doesn't compile with cpp11 0.1. 
   
   https://issues.apache.org/jira/browse/ARROW-10774


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson closed pull request #8808: ARROW-10774: [R] Set minimum cpp11 version

Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #8808:
URL: https://github.com/apache/arrow/pull/8808


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #8808: ARROW-10774: [R] Set minimum cpp11 version

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8808:
URL: https://github.com/apache/arrow/pull/8808#discussion_r533643340



##########
File path: r/DESCRIPTION
##########
@@ -48,7 +48,7 @@ Suggests:
     rmarkdown,
     testthat,
     tibble
-LinkingTo: cpp11
+LinkingTo: cpp11 (>= 0.2.0)

Review comment:
       Alright, if you tested and 0.2.0 works, that's ok with me




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8808: ARROW-10774: [R] Set minimum cpp11 version

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8808:
URL: https://github.com/apache/arrow/pull/8808#issuecomment-736161920


   https://issues.apache.org/jira/browse/ARROW-10774


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on a change in pull request #8808: [R] minimum version for cpp11

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #8808:
URL: https://github.com/apache/arrow/pull/8808#discussion_r533012545



##########
File path: r/DESCRIPTION
##########
@@ -48,7 +48,7 @@ Suggests:
     rmarkdown,
     testthat,
     tibble
-LinkingTo: cpp11
+LinkingTo: cpp11 (>= 0.2.0)

Review comment:
       I believe we might actually require `>= 0.2.3`, looking at https://github.com/r-lib/cpp11/releases. I think that was the point at which we switched off of the vendored copy. @bkietz do you recall?  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] traversc commented on a change in pull request #8808: ARROW-10774: [R] Set minimum cpp11 version

Posted by GitBox <gi...@apache.org>.
traversc commented on a change in pull request #8808:
URL: https://github.com/apache/arrow/pull/8808#discussion_r533021128



##########
File path: r/DESCRIPTION
##########
@@ -48,7 +48,7 @@ Suggests:
     rmarkdown,
     testthat,
     tibble
-LinkingTo: cpp11
+LinkingTo: cpp11 (>= 0.2.0)

Review comment:
       I tested out all archived versions on CRAN, and 0.2.0 compiled. But it probably doesn't hurt to require the latest. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org