You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/07/01 20:26:42 UTC

[GitHub] [storm] krichter722 commented on a change in pull request #3055: STORM-3440: client: fix all checkstyle warnings

krichter722 commented on a change in pull request #3055: STORM-3440: client: fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3055#discussion_r299204225
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/Config.java
 ##########
 @@ -1771,38 +1774,47 @@ private static List getRegisteredDecorators(Map<String, Object> conf) {
         return ret;
     }
 
+    @SuppressWarnings("checkstyle:OverloadMethodsDeclarationOrder")
 
 Review comment:
   Do you prefer static and non-static methods overloading each other next to each other? Or should static remain separated from non-static?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services