[GitHub] [lucene] magibney commented on a change in pull request #208: LUCENE-10023: Add support for multi-token post-analysis DocValues

[GitBox <gi...@apache.org>]

magibney commented on a change in pull request #208:
URL: https://github.com/apache/lucene/pull/208#discussion_r666384638



##########
File path: lucene/core/src/java/org/apache/lucene/index/DocValuesIterator.java
##########
@@ -19,7 +19,13 @@
 import java.io.IOException;
 import org.apache.lucene.search.DocIdSetIterator;
 
-abstract class DocValuesIterator extends DocIdSetIterator {
+/** TODO: flesh this out since we made this class public */
+public abstract class DocValuesIterator extends DocIdSetIterator {

Review comment:
       Ahh absolutely right; I overlooked this when extricating the Lucene changes from a mixed Lucene/Solr branch. It serves no purpose here, and _if_ it's going to be considered at all, it would certainly be considered separately from this issue/PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org