[GitHub] [superset] pkdotson commented on a change in pull request #12782: feat: reset metrics on dataset change

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #12782:
URL: https://github.com/apache/superset/pull/12782#discussion_r569011801



##########
File path: superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover.jsx
##########
@@ -123,6 +123,9 @@ export default class AdhocMetricEditPopover extends React.PureComponent {
         adhocMetricLabel: this.state.adhocMetric?.getDefaultLabel(),
       });
     }
+    if (prevProps.datasource !== this.props.datasource) {

Review comment:
       This does refer's to the the datasource name. datasource is datasource name being passed down




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org