You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Mickael Maison <mi...@gmail.com> on 2021/10/18 15:08:03 UTC

[DISCUSS] KIP-784: Add top-level error code field to DescribeLogDirsResponse

Hi,

I wrote a very minor KIP that proposes adding a top-level error code
field to DescribeLogDirsResponse:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-784%3A+Add+top-level+error+code+field+to+DescribeLogDirsResponse

Please let me know if you have any feedback.
Thanks

Re: [DISCUSS] KIP-784: Add top-level error code field to DescribeLogDirsResponse

Posted by Mickael Maison <mi...@gmail.com>.

Hi Magnus,

That's a good point, I've updated the KIP.

Considering it's a very small KIP, if I don't see any more feedback,
I'll start a vote in the next couple of days.

Thanks,
Mickael

On Mon, Nov 22, 2021 at 11:05 AM Magnus Edenhill <ma...@edenhill.se> wrote:
>
> Hey Mickael and thanks for the KIP.
>
> I'm a bit late to the game, but one small nit for consistency:
> The global response error codes are typically at the start of the response,
> usually right after the ThrottleTime.
> This also makes it easier for the response parser to assign the global
> error for each sub-result, if needed.
>
> Thanks,
> Magnus
>
>
> Den mån 18 okt. 2021 kl 17:08 skrev Mickael Maison <mickael.maison@gmail.com
> >:
>
> > Hi,
> >
> > I wrote a very minor KIP that proposes adding a top-level error code
> > field to DescribeLogDirsResponse:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-784%3A+Add+top-level+error+code+field+to+DescribeLogDirsResponse
> >
> > Please let me know if you have any feedback.
> > Thanks
> >

Re: [DISCUSS] KIP-784: Add top-level error code field to DescribeLogDirsResponse

Posted by Magnus Edenhill <ma...@edenhill.se>.

Hey Mickael and thanks for the KIP.

I'm a bit late to the game, but one small nit for consistency:
The global response error codes are typically at the start of the response,
usually right after the ThrottleTime.
This also makes it easier for the response parser to assign the global
error for each sub-result, if needed.

Thanks,
Magnus


Den mån 18 okt. 2021 kl 17:08 skrev Mickael Maison <mickael.maison@gmail.com
>:

> Hi,
>
> I wrote a very minor KIP that proposes adding a top-level error code
> field to DescribeLogDirsResponse:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-784%3A+Add+top-level+error+code+field+to+DescribeLogDirsResponse
>
> Please let me know if you have any feedback.
> Thanks
>